From: David Miller <davem@davemloft.net>
To: cwang@twopensource.com
Cc: jiri@resnulli.us, netdev@vger.kernel.org, fbl@redhat.com,
erik.hugne@ericsson.com
Subject: Re: [patch net-next] team: set IFF_TEAM_PORT priv_flag after rx_handler is registered
Date: Mon, 25 Aug 2014 17:36:11 -0700 (PDT) [thread overview]
Message-ID: <20140825.173611.1629035794825074435.davem@davemloft.net> (raw)
In-Reply-To: <CAHA+R7NeOhhHu+RJ-zyOt_3PrY7qYk98r7gjH9Qz3Vf=Za_REA@mail.gmail.com>
From: Cong Wang <cwang@twopensource.com>
Date: Mon, 25 Aug 2014 14:11:15 -0700
> On Mon, Aug 25, 2014 at 12:38 PM, Jiri Pirko <jiri@resnulli.us> wrote:
>> When one tries to add eth as a port into team and that eth is already in
>> use by other rx_handler device (macvlan, bond, bridge, ...) a bug in
>> team_port_add() causes that IFF_TEAM_PORT flag is set before rx_handler
>> is registered. In between, netdev nofifier is called and
>> team_device_event() sees IFF_TEAM_PORT and thinks that rx_handler_data
>> pointer is set to team_port. But it isn't.
>>
>> Fix this by reordering rx_handler register and IFF_TEAM_PORT priv flag
>> set so it is very similar to how bonding does this.
>>
>> Reported-by: Erik Hugne <erik.hugne@ericsson.com>
>> Introduced-by: 3d249d4ca7 "net: introduce ethernet teaming device"
>> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
>
> For consistence, we use "Fixes:" instead of "Introduced-by:".
> Just fyi.
I fixed this up and applied the patch, thanks.
prev parent reply other threads:[~2014-08-26 0:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 19:38 [patch net-next] team: set IFF_TEAM_PORT priv_flag after rx_handler is registered Jiri Pirko
2014-08-25 21:11 ` Cong Wang
2014-08-26 0:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825.173611.1629035794825074435.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cwang@twopensource.com \
--cc=erik.hugne@ericsson.com \
--cc=fbl@redhat.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).