* linux/if_bridge.h no longer self contained (again)
@ 2014-07-30 22:05 Florian Fainelli
2014-07-30 23:20 ` Cong Wang
0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2014-07-30 22:05 UTC (permalink / raw)
To: netdev, David Miller, Cong Wang, Gregory Fong, carlos; +Cc: eblake, Kumar Gala
Hi all,
Gregory and I bumped into the following issue:
http://linux-kernel.2935.n7.nabble.com/if-bridge-h-include-in6-h-for-struct-in6-addr-use-td580828.html
also reported here: https://bugzilla.redhat.com/show_bug.cgi?id=895141
We tracked down the following Linux changes:
ee262ad827f89e2dc7851ec2986953b5b125c6bc inet: defines IPPROTO_*
needed for module alias generation
cfd280c91253cc28e4919e349fa7a813b63e71e8 net: sync some IP headers with glibc
and the following glibc change:
6c82a2f8d7c8e21e39237225c819f182ae438db3 Coordinate IPv6 definitions
for Linux and glibc
but as far as we could see and test it, this particular issue is still
present in the current Linux kernel.
What would be the recommended ways to move forward?
Should we keep a local change that includes netinet/in6.h and just
hope it does not cause any re-definitions?
Thanks!
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux/if_bridge.h no longer self contained (again)
2014-07-30 22:05 linux/if_bridge.h no longer self contained (again) Florian Fainelli
@ 2014-07-30 23:20 ` Cong Wang
2014-08-26 1:18 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Cong Wang @ 2014-07-30 23:20 UTC (permalink / raw)
To: Florian Fainelli
Cc: netdev, David Miller, Gregory Fong, carlos, eblake, Kumar Gala
Hi,
On Wed, Jul 30, 2014 at 3:05 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> What would be the recommended ways to move forward?
>
> Should we keep a local change that includes netinet/in6.h and just
> hope it does not cause any re-definitions?
>
I think we should just #include <linux/in6.h> since the redefinition error
was already fixed.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux/if_bridge.h no longer self contained (again)
2014-07-30 23:20 ` Cong Wang
@ 2014-08-26 1:18 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2014-08-26 1:18 UTC (permalink / raw)
To: xiyou.wangcong; +Cc: f.fainelli, netdev, gregory.0xf0, carlos, eblake, galak
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Wed, 30 Jul 2014 16:20:07 -0700
> On Wed, Jul 30, 2014 at 3:05 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
>>
>> What would be the recommended ways to move forward?
>>
>> Should we keep a local change that includes netinet/in6.h and just
>> hope it does not cause any re-definitions?
>>
>
> I think we should just #include <linux/in6.h> since the redefinition error
> was already fixed.
Someone please submit a patch to do so, and please include all of the context
such as the commits references in Florian's initial email of this thread.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-26 1:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-30 22:05 linux/if_bridge.h no longer self contained (again) Florian Fainelli
2014-07-30 23:20 ` Cong Wang
2014-08-26 1:18 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).