From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sitsofe Wheeler <sitsofe@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jason Wang <jasowang@redhat.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
linux-kernel@vger.kernel.org,
Daniel Borkmann <dborkman@redhat.com>,
netdev@vger.kernel.org, devel@linuxdriverproject.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [hyperv] BUG at drivers/hv/channel.c:462 while changing MTU
Date: Mon, 25 Aug 2014 12:36:48 +0300 [thread overview]
Message-ID: <20140825093648.GB5046@mwanda> (raw)
In-Reply-To: <20140819123655.GC12160@sucs.org>
The code here is:
drivers/hv/channel.c
460 BUG_ON(ret != 0);
461 t = wait_for_completion_timeout(&info->waitevent, 5*HZ);
462 BUG_ON(t == 0);
So it calls BUG_ON() if the teardown takes more than 5 seconds. It's
most likely that there is a race condition somewhere. It's also
possible that it's just taking longer than 5 seconds for some odd
reason and the bug would go away if we raised it to 60 seconds.
BUG_ON() after 5 seconds seems like a very aggressive thing.
regards,
dan carpenter
next prev parent reply other threads:[~2014-08-25 9:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 12:36 [hyperv] BUG at drivers/hv/channel.c:462 while changing MTU Sitsofe Wheeler
2014-08-19 21:29 ` Haiyang Zhang
2014-08-20 3:41 ` Sitsofe Wheeler
2014-08-25 10:48 ` Richard Weinberger
2014-08-25 14:53 ` KY Srinivasan
2014-08-25 15:07 ` Richard Weinberger
2014-08-25 17:29 ` KY Srinivasan
2014-08-25 9:36 ` Dan Carpenter [this message]
2014-08-25 17:34 ` KY Srinivasan
2014-08-25 17:50 ` Greg Kroah-Hartman
2014-08-25 18:05 ` KY Srinivasan
2014-08-25 21:43 ` Sitsofe Wheeler
2014-08-25 21:48 ` KY Srinivasan
2014-08-27 9:33 ` Sitsofe Wheeler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825093648.GB5046@mwanda \
--to=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sitsofe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).