From: David Gibson <dgibson@redhat.com>
To: Pankaj Gupta <pagupta@redhat.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
davem@davemloft.net, jasowang@redhat.com, mst@redhat.com,
vfalico@gmail.com, edumazet@google.com, vyasevic@redhat.com,
hkchu@google.com, wuzhy@linux.vnet.ibm.com, xemul@parallels.com,
therbert@google.com, bhutchings@solarflare.com, xii@google.com,
stephen@networkplumber.org
Subject: Re: [RFC 3/4] tuntap: reduce the size of tun_struct by using flex array
Date: Mon, 25 Aug 2014 11:35:11 +1000 [thread overview]
Message-ID: <20140825113511.cc52779b6c2f13c9abef23ee@redhat.com> (raw)
In-Reply-To: <1408369040-1216-4-git-send-email-pagupta@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
On Mon, 18 Aug 2014 19:07:19 +0530
Pankaj Gupta <pagupta@redhat.com> wrote:
> This patch switches to flex array to implement the flow caches, it brings
> several advantages:
>
> - Reduce the size of the tun_struct structure, which allows us to increase the
> upper limit of queues in future.
> - Avoid higher order memory allocation. It will be useful when switching to
> pure hashing in flow cache which may demand a larger size array in future.
>
> After this patch, the size of tun_struct on x86_64 reduced from 8512 to
> 328
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
Reviewed-by: David Gibson <dgibson@redhat.com>
--
David Gibson <dgibson@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-25 1:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 13:37 [RFC 0/4] Increase the limit of tuntap queues Pankaj Gupta
2014-08-18 13:37 ` [RFC 1/4] net: allow large number of rx queues Pankaj Gupta
2014-08-18 17:43 ` Sergei Shtylyov
2014-08-19 5:15 ` Pankaj Gupta
2014-08-18 13:37 ` [RFC 2/4] tuntap: Publish tuntap maximum number of queues as module_param Pankaj Gupta
2014-08-20 10:58 ` Jiri Pirko
2014-08-20 11:17 ` Michael S. Tsirkin
2014-08-20 11:46 ` Jiri Pirko
2014-08-20 11:49 ` Michael S. Tsirkin
2014-08-20 11:53 ` Jiri Pirko
2014-08-21 4:30 ` Jason Wang
2014-08-22 11:52 ` Pankaj Gupta
2014-08-24 11:14 ` Michael S. Tsirkin
2014-08-25 2:57 ` Jason Wang
2014-08-26 15:30 ` Pankaj Gupta
2014-08-18 13:37 ` [RFC 3/4] tuntap: reduce the size of tun_struct by using flex array Pankaj Gupta
2014-08-25 1:35 ` David Gibson [this message]
2014-08-18 13:37 ` [RFC 4/4] tuntap: Increase the number of queues in tun Pankaj Gupta
2014-08-25 1:37 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825113511.cc52779b6c2f13c9abef23ee@redhat.com \
--to=dgibson@redhat.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkchu@google.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pagupta@redhat.com \
--cc=stephen@networkplumber.org \
--cc=therbert@google.com \
--cc=vfalico@gmail.com \
--cc=vyasevic@redhat.com \
--cc=wuzhy@linux.vnet.ibm.com \
--cc=xemul@parallels.com \
--cc=xii@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).