From: Stephen Hemminger <stephen@networkplumber.org>
To: netdev@vger.kernel.org
Subject: Fw: [Bug 83131] New: can: ti_hecc.c: closing device while receiving can messages, effectively disables all socket transfer
Date: Mon, 25 Aug 2014 14:45:07 -0700 [thread overview]
Message-ID: <20140825144507.09c952cf@urahara> (raw)
Begin forwarded message:
Date: Sun, 24 Aug 2014 06:07:49 -0700
From: "bugzilla-daemon@bugzilla.kernel.org" <bugzilla-daemon@bugzilla.kernel.org>
To: "stephen@networkplumber.org" <stephen@networkplumber.org>
Subject: [Bug 83131] New: can: ti_hecc.c: closing device while receiving can messages, effectively disables all socket transfer
https://bugzilla.kernel.org/show_bug.cgi?id=83131
Bug ID: 83131
Summary: can: ti_hecc.c: closing device while receiving can
messages, effectively disables all socket transfer
Product: Networking
Version: 2.5
Kernel Version: 3.16.1
Hardware: All
OS: Linux
Tree: PREEMPT_RT
Status: NEW
Severity: normal
Priority: P1
Component: Other
Assignee: shemminger@linux-foundation.org
Reporter: jan.sondhauss@gmail.com
Regression: No
drivers/net/can/ti_hecc.c:
When closing the can device, its not ensured that it gets removed from the
socket-poll list.
The problem here lies in the ti_hecc_rx_poll() function which returns early
when the device is closed already.
This leads to napi_complete() never being called, thus the device stays in the
napi's poll list forever and every task reading from any socket is polling this
device. The system is now basically unreachable.
The patch attached seams to fix this problem by removing the early return in
the ti_hecc_rx_poll function. But I'm not sure whether this is the correct
solution.
--
You are receiving this mail because:
You are the assignee for the bug.
reply other threads:[~2014-08-25 21:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825144507.09c952cf@urahara \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox