netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: lftan@altera.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	lftan.linux@gmail.com, peppe.cavallaro@st.com,
	vbridger@altera.com
Subject: Re: [PATCH] net: stmmac: fix warning from Sparse for socfpga
Date: Wed, 27 Aug 2014 16:33:43 -0700 (PDT)	[thread overview]
Message-ID: <20140827.163343.715764078341662382.davem@davemloft.net> (raw)
In-Reply-To: <1409037076-14775-1-git-send-email-lftan@altera.com>

From: Ley Foon Tan <lftan@altera.com>
Date: Tue, 26 Aug 2014 15:11:16 +0800

> @@ -119,7 +119,8 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac *dwmac, struct device *
>  			return -EINVAL;
>  		}
>  
> -		dwmac->splitter_base = (void *)devm_ioremap_resource(dev,
> +		dwmac->splitter_base =
> +			(void __iomem *)devm_ioremap_resource(dev,
>  			&res_splitter);

Please either put this entire call on one line (it'll only be slightly
over 80 columns, which is fine), or indent it properly.

And by properly I meant that the second and subsequent lines of a function
call must be indented precisely to the first column after the openning
parenthesis of the function call on the first line.  You must use the
appropriate number of TAB and SPACE characters necessary to do so.

If it is indented using only TAB characters, it is very likely that you
are doing it wrong.

Thanks.

  parent reply	other threads:[~2014-08-27 23:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-26  7:11 [PATCH] net: stmmac: fix warning from Sparse for socfpga Ley Foon Tan
2014-08-26  7:24 ` Giuseppe CAVALLARO
2014-08-26  7:47   ` Ley Foon Tan
2014-08-26  8:04     ` Giuseppe CAVALLARO
2014-08-26  8:11       ` Ley Foon Tan
2014-08-27 23:33 ` David Miller [this message]
2014-08-28  3:33   ` Ley Foon Tan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140827.163343.715764078341662382.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=lftan.linux@gmail.com \
    --cc=lftan@altera.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    --cc=vbridger@altera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).