Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: peppe.cavallaro@st.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH (net.git) (v2)] stmmac: ptp: fix the reference clock
Date: Fri, 29 Aug 2014 19:55:55 -0700 (PDT)	[thread overview]
Message-ID: <20140829.195555.556471914848484099.davem@davemloft.net> (raw)
In-Reply-To: <1409128669-14276-1-git-send-email-peppe.cavallaro@st.com>

From: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Date: Wed, 27 Aug 2014 10:37:49 +0200

> The PTP reference clock, used for setting the addend in the Timestamp Addend
> Register, was erroneously hard-coded (as reported in the databook just as
> example).
> 
> The patch removes the macro named: STMMAC_SYSCLOCK and allows to use a
> reference clock (clk_ptp_ref_i) that can be passed from the platform.
> 
> If not passed, the main driver clock will be used as default; note that
> this can be fine on some platforms.
> 
> Note that, prior this patch, using the old STMMAC_SYSCLOCK on some platforms,
> as side effect, the ptp clock can move faster/slower than the system clock.
> 
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> ---
> v2: fixed the release function in case of the new clock is not provided by the
>     platform.

Applied.

  reply	other threads:[~2014-08-30  2:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-26  6:04 [PATCH (net.git)] stmmac: ptp: fix the reference clock Giuseppe Cavallaro
2014-08-27  8:37 ` [PATCH (net.git) (v2)] " Giuseppe Cavallaro
2014-08-30  2:55   ` David Miller [this message]
2014-08-27 23:26 ` [PATCH (net.git)] " David Miller
2014-08-28  6:02   ` Giuseppe CAVALLARO

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140829.195555.556471914848484099.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox