From: David Miller <davem@davemloft.net>
To: peppe.cavallaro@st.com
Cc: netdev@vger.kernel.org, andre.draszik@st.com, hdegoede@redhat.com
Subject: Re: [PATCH (net.git)] stmmac: fix dma api misuse
Date: Fri, 29 Aug 2014 19:56:05 -0700 (PDT) [thread overview]
Message-ID: <20140829.195605.177395605884169802.davem@davemloft.net> (raw)
In-Reply-To: <1409131620-16888-1-git-send-email-peppe.cavallaro@st.com>
From: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Date: Wed, 27 Aug 2014 11:27:00 +0200
> Enabling DMA_API_DEBUG, warnings are reported at runtime
> because the device driver frees DMA memory with wrong functions
> and it does not call dma_mapping_error after mapping dma memory.
>
> The first problem is fixed by of introducing a flag that helps us
> keeping track which mapping technique was used, so that we can use
> the right API for unmap.
> This approach was inspired by the e1000 driver, which uses a similar
> technique.
>
> Signed-off-by: Andre Draszik <andre.draszik@st.com>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Reviewed-by: Denis Kirjanov <kda@linux-powerpc.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
Applied.
prev parent reply other threads:[~2014-08-30 2:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 9:52 stmmac: Needs to check dma_map return values (oops when build with CONFIG_DMA_API_DEBUG) Hans de Goede
2014-08-01 10:11 ` Denis Kirjanov
2014-08-18 5:41 ` Giuseppe CAVALLARO
2014-08-19 20:56 ` Denis Kirjanov
2014-08-22 6:53 ` Giuseppe CAVALLARO
2014-08-27 9:27 ` [PATCH (net.git)] stmmac: fix dma api misuse Giuseppe Cavallaro
2014-08-30 2:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140829.195605.177395605884169802.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andre.draszik@st.com \
--cc=hdegoede@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).