* [PATCH net-next] be2net: Use dev_consume_skb_any() in the non-drop path
@ 2014-08-28 15:53 Rick Jones
2014-08-30 3:37 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Rick Jones @ 2014-08-28 15:53 UTC (permalink / raw)
To: netdev; +Cc: davem, sathya.perla, subbu.seetharaman, ajit.khaparde
From: Rick Jones <rick.jones2@hp.com>
The be2net driver was still using dev_kfree_skb_any() in a "normal"
skb freeing path. This rather clutters perf top -G -e skb_kfree_skb
profiling.
Signed-off-by: Rick Jones <rick.jones2@hp.com>
---
Briefly beaten-on with some netperf TCP_RR tests, but not tried with
perf because I'm too clueless to get the 3.17.0-rc1 perf and all it
seems to want onto my "Precise" test system :(
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index 93ff8ef..42e9cea 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -1991,7 +1991,7 @@ static u16 be_tx_compl_process(struct be_adapter *adapter,
queue_tail_inc(txq);
} while (cur_index != last_index);
- dev_kfree_skb_any(sent_skb);
+ dev_consume_skb_any(sent_skb);
return num_wrbs;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] be2net: Use dev_consume_skb_any() in the non-drop path
2014-08-28 15:53 [PATCH net-next] be2net: Use dev_consume_skb_any() in the non-drop path Rick Jones
@ 2014-08-30 3:37 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-08-30 3:37 UTC (permalink / raw)
To: raj; +Cc: netdev, sathya.perla, subbu.seetharaman, ajit.khaparde
From: raj@tardy.usa.hp.com (Rick Jones)
Date: Thu, 28 Aug 2014 08:53:16 -0700 (PDT)
> From: Rick Jones <rick.jones2@hp.com>
>
> The be2net driver was still using dev_kfree_skb_any() in a "normal"
> skb freeing path. This rather clutters perf top -G -e skb_kfree_skb
> profiling.
>
> Signed-off-by: Rick Jones <rick.jones2@hp.com>
Applied, thanks Rick.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-30 3:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-28 15:53 [PATCH net-next] be2net: Use dev_consume_skb_any() in the non-drop path Rick Jones
2014-08-30 3:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).