From: David Miller <davem@davemloft.net>
To: manish.chopra@qlogic.com
Cc: netdev@vger.kernel.org, Ariel.Elior@qlogic.com, Yuval.Mintz@qlogic.com
Subject: Re: [PATCH net] bnx2x: Configure device endianity on driver load and reset endianity on removal.
Date: Mon, 01 Sep 2014 14:53:14 -0700 (PDT) [thread overview]
Message-ID: <20140901.145314.1237097170646182877.davem@davemloft.net> (raw)
In-Reply-To: <31AFFC7280259C4184970ABA9AFE8B93E0800207@avmb3.qlogic.org>
From: Manish Chopra <manish.chopra@qlogic.com>
Date: Mon, 1 Sep 2014 15:33:20 +0000
>> -----Original Message-----
>> This patch fixes this case from both ends:
>> 1) Return endianity to original values on shutdown (in case little endian kernel
>> boots after we shutdown).
>> 2) Do not rely on HW reset values when loading driver in little endian kernel
>> but configure them explicitly (in case previous kernel was big endian and did
>> not reset the HW).
...
> David, Please drop this patch as it might create issue for VFs.
> I will send updated V2 patch with proper fix.
I think part #2 is the only reasonable part of this patch, and that's
what you'll have to backport to -stable kernels to sort this out
properly.
Adding "unconfiguration" hacks into a driver to deal with driver bugs
is really not kosher, sorry.
next prev parent reply other threads:[~2014-09-01 21:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 14:17 [PATCH net] bnx2x: Configure device endianity on driver load and reset endianity on removal Manish Chopra
2014-09-01 15:33 ` Manish Chopra
2014-09-01 21:53 ` David Miller [this message]
2014-09-02 5:47 ` Yuval Mintz
2014-09-02 5:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901.145314.1237097170646182877.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ariel.Elior@qlogic.com \
--cc=Yuval.Mintz@qlogic.com \
--cc=manish.chopra@qlogic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).