From: David Miller <davem@davemloft.net>
To: mugunthanvnm@ti.com
Cc: netdev@vger.kernel.org
Subject: Re: [net PATCH 1/1] drivers: net: cpsw: dual_emac: fix reducing of rx descriptor during ifdown
Date: Mon, 01 Sep 2014 18:31:08 -0700 (PDT) [thread overview]
Message-ID: <20140901.183108.784916699845611422.davem@davemloft.net> (raw)
In-Reply-To: <1409304145-26179-1-git-send-email-mugunthanvnm@ti.com>
From: Mugunthan V N <mugunthanvnm@ti.com>
Date: Fri, 29 Aug 2014 14:52:25 +0530
> In Dual EMAC, when both interface are up and while doing ifdown with heavy
> traffic then skbs already processed by DMA from that slave emac has to be
> requeued as still the other interface is up and running.
>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
I don't see why this is important.
If the packet arrived via the down interface, let it be dropped and
the sender will simply resend if necessary.
Also you are putting this new multi-slave logic under the "status < 0"
condition as well as the interface being down, that's not right either.
next prev parent reply other threads:[~2014-09-02 1:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 9:22 [net PATCH 1/1] drivers: net: cpsw: dual_emac: fix reducing of rx descriptor during ifdown Mugunthan V N
2014-09-02 1:31 ` David Miller [this message]
2014-09-02 9:21 ` Mugunthan V N
2014-09-02 18:54 ` David Miller
2014-09-03 7:16 ` Mugunthan V N
2014-09-03 17:07 ` Mugunthan V N
2014-09-05 21:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901.183108.784916699845611422.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).