* [PATCH net-next] net: dsa: make dsa_pack_type static
@ 2014-08-29 19:42 Florian Fainelli
2014-09-02 3:42 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2014-08-29 19:42 UTC (permalink / raw)
To: netdev; +Cc: davem, Florian Fainelli, Fengguang Wu
net/dsa/dsa.c:624:20: sparse: symbol 'dsa_pack_type' was not declared.
Should it be static?
Fixes: 3e8a72d1dae374 ("net: dsa: reduce number of protocol hooks")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
net/dsa/dsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c
index 484f695351a7..61f145c44555 100644
--- a/net/dsa/dsa.c
+++ b/net/dsa/dsa.c
@@ -629,7 +629,7 @@ static int dsa_switch_rcv(struct sk_buff *skb, struct net_device *dev,
return dst->ops->rcv(skb, dev, pt, orig_dev);
}
-struct packet_type dsa_pack_type __read_mostly = {
+static struct packet_type dsa_pack_type __read_mostly = {
.type = cpu_to_be16(ETH_P_XDSA),
.func = dsa_switch_rcv,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: dsa: make dsa_pack_type static
2014-08-29 19:42 [PATCH net-next] net: dsa: make dsa_pack_type static Florian Fainelli
@ 2014-09-02 3:42 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-09-02 3:42 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev, fengguang.wu
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Fri, 29 Aug 2014 12:42:07 -0700
> net/dsa/dsa.c:624:20: sparse: symbol 'dsa_pack_type' was not declared.
> Should it be static?
>
> Fixes: 3e8a72d1dae374 ("net: dsa: reduce number of protocol hooks")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-02 3:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-29 19:42 [PATCH net-next] net: dsa: make dsa_pack_type static Florian Fainelli
2014-09-02 3:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).