From: David Miller <davem@davemloft.net>
To: mugunthanvnm@ti.com
Cc: netdev@vger.kernel.org
Subject: Re: [net PATCH 1/1] drivers: net: cpsw: dual_emac: fix reducing of rx descriptor during ifdown
Date: Tue, 02 Sep 2014 11:54:34 -0700 (PDT) [thread overview]
Message-ID: <20140902.115434.1276391011837651390.davem@davemloft.net> (raw)
In-Reply-To: <54058C01.3010402@ti.com>
From: Mugunthan V N <mugunthanvnm@ti.com>
Date: Tue, 2 Sep 2014 14:51:05 +0530
> When ifup and ifdown is run continuously, for each spilled packet (for
> interface which is down) from DMA, the total number of rx descriptor
> goes down and at one instance all the descriptor is lost and both the
> interface stops working.
>
> To recover from this we need to put down both the interface and open the
> interface which will re-init the DMA which intern queues fresh set of
> skbs for rx.
But you still should not receive packets for a netdev which is down.
As far as I can tell, you're feeding it into the stack still.
Also this doesn't explain why the "status < 0" case applies to this
new logic, you have not explained that at all.
next prev parent reply other threads:[~2014-09-02 18:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 9:22 [net PATCH 1/1] drivers: net: cpsw: dual_emac: fix reducing of rx descriptor during ifdown Mugunthan V N
2014-09-02 1:31 ` David Miller
2014-09-02 9:21 ` Mugunthan V N
2014-09-02 18:54 ` David Miller [this message]
2014-09-03 7:16 ` Mugunthan V N
2014-09-03 17:07 ` Mugunthan V N
2014-09-05 21:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902.115434.1276391011837651390.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).