From: David Miller <davem@davemloft.net>
To: brouer@redhat.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 5/9] net: Have xmit_list() signal more==true when appropriate.
Date: Tue, 02 Sep 2014 13:55:15 -0700 (PDT) [thread overview]
Message-ID: <20140902.135515.1879196973068806729.davem@davemloft.net> (raw)
In-Reply-To: <20140902092538.7987db64@redhat.com>
From: Jesper Dangaard Brouer <brouer@redhat.com>
Date: Tue, 2 Sep 2014 09:25:38 +0200
> On Mon, 01 Sep 2014 15:24:59 -0700 (PDT) David Miller <davem@davemloft.net> wrote:
>
>> if (unlikely(!dev_xmit_complete(rc))) {
>> skb->next = next;
>> goto out;
>
> In the exit case (!dev_xmit_complete(rc)) is it,
> 1. the responsibility of the driver to "flush" the tail, or
> 2. do we depend on qdisc or softirq to be reactivated soonish?
I think the driver will have to do it, much like it must do so when
the queue is stopped.
prev parent reply other threads:[~2014-09-02 20:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 22:24 [PATCH 5/9] net: Have xmit_list() signal more==true when appropriate David Miller
2014-09-02 7:25 ` Jesper Dangaard Brouer
2014-09-02 20:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902.135515.1879196973068806729.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brouer@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).