From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: netdev@vger.kernel.org, klassert@mathematik.tu-chemnitz.de
Subject: Re: [PATCH] 3c59x: avoid panic in boomerang_start_xmit when finding page address:
Date: Tue, 02 Sep 2014 14:08:46 -0700 (PDT) [thread overview]
Message-ID: <20140902.140846.27292264952407548.davem@davemloft.net> (raw)
In-Reply-To: <1409676715-2291-1-git-send-email-nhorman@tuxdriver.com>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Tue, 2 Sep 2014 12:51:55 -0400
> @@ -2177,10 +2177,10 @@ boomerang_start_xmit(struct sk_buff *skb, struct net_device *dev)
> skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
>
> vp->tx_ring[entry].frag[i+1].addr =
> - cpu_to_le32(pci_map_single(
> - VORTEX_PCI(vp),
> - (void *)skb_frag_address(frag),
> - skb_frag_size(frag), PCI_DMA_TODEVICE));
> + cpu_to_le32(skb_frag_dma_map(
> + &VORTEX_PCI(vp)->dev,
> + frag,
> + frag->page_offset, frag->size, PCI_DMA_TODEVICE));
You need to adjust the final argument to be "DMA_TO_DEVICE".
next prev parent reply other threads:[~2014-09-02 21:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 16:51 [PATCH] 3c59x: avoid panic in boomerang_start_xmit when finding page address: Neil Horman
2014-09-02 21:08 ` David Miller [this message]
2014-09-03 10:17 ` [PATCH v2] " Neil Horman
2014-09-04 3:58 ` David Miller
[not found] ` <1409825618-30785-1-git-send-email-nhorman@tuxdriver.com>
2014-09-06 0:24 ` [PATCH v3] " David Miller
2014-09-07 20:43 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902.140846.27292264952407548.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=klassert@mathematik.tu-chemnitz.de \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).