From: Jesper Dangaard Brouer <brouer@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: brouer@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH 5/9] net: Have xmit_list() signal more==true when appropriate.
Date: Tue, 2 Sep 2014 09:25:38 +0200 [thread overview]
Message-ID: <20140902092538.7987db64@redhat.com> (raw)
In-Reply-To: <20140901.152459.592105486574617399.davem@davemloft.net>
On Mon, 01 Sep 2014 15:24:59 -0700 (PDT) David Miller <davem@davemloft.net> wrote:
> diff --git a/net/core/dev.c b/net/core/dev.c
> index f0ed5a6..6d82194 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -2600,7 +2600,7 @@ netdev_features_t netif_skb_features(struct sk_buff *skb)
> EXPORT_SYMBOL(netif_skb_features);
>
> static int xmit_one(struct sk_buff *skb, struct net_device *dev,
> - struct netdev_queue *txq)
> + struct netdev_queue *txq, bool more)
> {
> unsigned int len;
> int rc;
> @@ -2610,7 +2610,7 @@ static int xmit_one(struct sk_buff *skb, struct net_device *dev,
>
> len = skb->len;
> trace_net_dev_start_xmit(skb, dev);
> - rc = netdev_start_xmit(skb, dev, txq, false);
> + rc = netdev_start_xmit(skb, dev, txq, more);
>
> trace_net_dev_xmit(skb, rc, dev, len);
>
> return rc;
> @@ -2626,7 +2626,7 @@ static struct sk_buff *xmit_list(struct sk_buff *first, struct net_device *dev,
> struct sk_buff *next = skb->next;
>
> skb->next = NULL;
> - rc = xmit_one(skb, dev, txq);
> + rc = xmit_one(skb, dev, txq, next != NULL);
Guess, the caller constructing the skb list to xmit_list() must make
sure all SKBs have the same TXQ.
> if (unlikely(!dev_xmit_complete(rc))) {
> skb->next = next;
> goto out;
In the exit case (!dev_xmit_complete(rc)) is it,
1. the responsibility of the driver to "flush" the tail, or
2. do we depend on qdisc or softirq to be reactivated soonish?
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2014-09-02 7:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 22:24 [PATCH 5/9] net: Have xmit_list() signal more==true when appropriate David Miller
2014-09-02 7:25 ` Jesper Dangaard Brouer [this message]
2014-09-02 20:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902092538.7987db64@redhat.com \
--to=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).