* [PATCH 5/9] net: Have xmit_list() signal more==true when appropriate.
@ 2014-09-01 22:24 David Miller
2014-09-02 7:25 ` Jesper Dangaard Brouer
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2014-09-01 22:24 UTC (permalink / raw)
To: netdev
Signed-off-by: David S. Miller <davem@davemloft.net>
---
net/core/dev.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index f0ed5a6..6d82194 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2600,7 +2600,7 @@ netdev_features_t netif_skb_features(struct sk_buff *skb)
EXPORT_SYMBOL(netif_skb_features);
static int xmit_one(struct sk_buff *skb, struct net_device *dev,
- struct netdev_queue *txq)
+ struct netdev_queue *txq, bool more)
{
unsigned int len;
int rc;
@@ -2610,7 +2610,7 @@ static int xmit_one(struct sk_buff *skb, struct net_device *dev,
len = skb->len;
trace_net_dev_start_xmit(skb, dev);
- rc = netdev_start_xmit(skb, dev, txq, false);
+ rc = netdev_start_xmit(skb, dev, txq, more);
trace_net_dev_xmit(skb, rc, dev, len);
return rc;
@@ -2626,7 +2626,7 @@ static struct sk_buff *xmit_list(struct sk_buff *first, struct net_device *dev,
struct sk_buff *next = skb->next;
skb->next = NULL;
- rc = xmit_one(skb, dev, txq);
+ rc = xmit_one(skb, dev, txq, next != NULL);
if (unlikely(!dev_xmit_complete(rc))) {
skb->next = next;
goto out;
@@ -2705,7 +2705,7 @@ int dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev,
}
}
- return xmit_one(skb, dev, txq);
+ return xmit_one(skb, dev, txq, false);
}
gso:
--
1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 5/9] net: Have xmit_list() signal more==true when appropriate.
2014-09-01 22:24 [PATCH 5/9] net: Have xmit_list() signal more==true when appropriate David Miller
@ 2014-09-02 7:25 ` Jesper Dangaard Brouer
2014-09-02 20:55 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Jesper Dangaard Brouer @ 2014-09-02 7:25 UTC (permalink / raw)
To: David Miller; +Cc: brouer, netdev
On Mon, 01 Sep 2014 15:24:59 -0700 (PDT) David Miller <davem@davemloft.net> wrote:
> diff --git a/net/core/dev.c b/net/core/dev.c
> index f0ed5a6..6d82194 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -2600,7 +2600,7 @@ netdev_features_t netif_skb_features(struct sk_buff *skb)
> EXPORT_SYMBOL(netif_skb_features);
>
> static int xmit_one(struct sk_buff *skb, struct net_device *dev,
> - struct netdev_queue *txq)
> + struct netdev_queue *txq, bool more)
> {
> unsigned int len;
> int rc;
> @@ -2610,7 +2610,7 @@ static int xmit_one(struct sk_buff *skb, struct net_device *dev,
>
> len = skb->len;
> trace_net_dev_start_xmit(skb, dev);
> - rc = netdev_start_xmit(skb, dev, txq, false);
> + rc = netdev_start_xmit(skb, dev, txq, more);
>
> trace_net_dev_xmit(skb, rc, dev, len);
>
> return rc;
> @@ -2626,7 +2626,7 @@ static struct sk_buff *xmit_list(struct sk_buff *first, struct net_device *dev,
> struct sk_buff *next = skb->next;
>
> skb->next = NULL;
> - rc = xmit_one(skb, dev, txq);
> + rc = xmit_one(skb, dev, txq, next != NULL);
Guess, the caller constructing the skb list to xmit_list() must make
sure all SKBs have the same TXQ.
> if (unlikely(!dev_xmit_complete(rc))) {
> skb->next = next;
> goto out;
In the exit case (!dev_xmit_complete(rc)) is it,
1. the responsibility of the driver to "flush" the tail, or
2. do we depend on qdisc or softirq to be reactivated soonish?
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 5/9] net: Have xmit_list() signal more==true when appropriate.
2014-09-02 7:25 ` Jesper Dangaard Brouer
@ 2014-09-02 20:55 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2014-09-02 20:55 UTC (permalink / raw)
To: brouer; +Cc: netdev
From: Jesper Dangaard Brouer <brouer@redhat.com>
Date: Tue, 2 Sep 2014 09:25:38 +0200
> On Mon, 01 Sep 2014 15:24:59 -0700 (PDT) David Miller <davem@davemloft.net> wrote:
>
>> if (unlikely(!dev_xmit_complete(rc))) {
>> skb->next = next;
>> goto out;
>
> In the exit case (!dev_xmit_complete(rc)) is it,
> 1. the responsibility of the driver to "flush" the tail, or
> 2. do we depend on qdisc or softirq to be reactivated soonish?
I think the driver will have to do it, much like it must do so when
the queue is stopped.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-02 20:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-01 22:24 [PATCH 5/9] net: Have xmit_list() signal more==true when appropriate David Miller
2014-09-02 7:25 ` Jesper Dangaard Brouer
2014-09-02 20:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).