netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: davem@davemloft.net, raghuram.kothakota@oracle.com,
	sowmini.varadhan@oracle.com
Cc: netdev@vger.kernel.org
Subject: [PATCH net-next v2 0/2] sunvnet: Reduce LDC message overhead.
Date: Tue, 2 Sep 2014 12:19:36 -0400	[thread overview]
Message-ID: <20140902161936.GA31516@oracle.com> (raw)


This patchset has an updated version of the v1 changes to reduce the
overhead from LDC messages. 

Re-submitting both patches for completeness.

- Send the minimum number of start and stop messages between producer
  and consumer. 
  Changes since v1 to pull out the unused label `again' and the unused
  `retries' variable

- When reading the descriptor rings, don't give up as soon as a dring
  that is not VIO_DESC_READY is found. 
  Changes since v1: the `again' label and retries variable belong to
  this patch.

I understand the Puristic objection to the polling-delay from
patch 2/2, but the practical reality is that when there is
a burst of data, and performance is actually most critical, 
the overhead from hastily sending an LDC stop and then 
processing another LDC start message is far greater than the 
slight penalty of a small delay when the network traffic is light.

Note that I'm separately working on moving the data handling to a
bottom-half or softirq context, where the poll-based delay will be
even less critical.  We could also consider adding a procfs or ethtool
based knob to disable the fudge-factored delay, and avoid the minor
polling penalty.

Sowmini Varadhan (2):
  Avoid sending superfluous LDC messages.
  Re-check for a VIO_DESC_READY data descriptor after short udelay()

 drivers/net/ethernet/sun/sunvnet.c | 87 ++++++++++++++++++++++++++++++++++----
 drivers/net/ethernet/sun/sunvnet.h |  4 ++
 2 files changed, 83 insertions(+), 8 deletions(-)

-- 
1.8.4.2

             reply	other threads:[~2014-09-02 16:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-02 16:19 Sowmini Varadhan [this message]
2014-09-05  5:37 ` [PATCH net-next v2 0/2] sunvnet: Reduce LDC message overhead David Miller
2014-09-08 14:38   ` Sowmini Varadhan
2014-09-08 14:43     ` David L Stevens
2014-09-10 14:04     ` Sowmini Varadhan
2014-09-10 22:25       ` David Miller
2014-09-10 22:37         ` Sowmini Varadhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140902161936.GA31516@oracle.com \
    --to=sowmini.varadhan@oracle.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=raghuram.kothakota@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).