From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexander Duyck <alexander.duyck@gmail.com>,
netdev@vger.kernel.org, brouer@redhat.com
Subject: Re: [net-next PATCH] qdisc: validate frames going through the direct_xmit path
Date: Wed, 3 Sep 2014 15:52:13 +0200 [thread overview]
Message-ID: <20140903155213.62ff4eff@redhat.com> (raw)
In-Reply-To: <1409751805.26422.32.camel@edumazet-glaptop2.roam.corp.google.com>
On Wed, 03 Sep 2014 06:43:25 -0700
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Wed, 2014-09-03 at 13:48 +0200, Jesper Dangaard Brouer wrote:
> > In commit 50cbe9ab5f8d ("net: Validate xmit SKBs right when we pull them
> > out of the qdisc") the validation code was moved out of dev_hard_start_xmit
> > and into dequeue_skb. However this overlooked the fact that we do not
> > always enqueue the skb onto a qdisc, if qdisc have flag TCQ_F_CAN_BYPASS.
> >
> > As a result Alex was seeing issues trying to connect to a vhost_net interface
> > after this patch was applied.
> >
> > Added a call to validate_xmit_skb in __dev_xmit_skb(), in the code path
> > for qdiscs with TCQ_F_CAN_BYPASS flag.
> >
> > Fixes: 50cbe9ab5f8d ("net: Validate xmit SKBs right when we pull them out of the qdisc")
> > Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> > Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
> > ---
>
> Jesper, you missed another spot, when there is no qdisc on the device.
>
> __dev_queue_xmit() calls dev_hard_start_xmit() around line 2886
>
> Could we try to not add a myriad of small patches ?
>
> Some of us will need to backport all of them.
I'm in the same backport situation ;-)
I'll send a V2 of this patch, with missed spot...
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2014-09-03 13:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 22:55 [PATCH] net: Validate frames going through the direct_xmit path Alexander Duyck
2014-09-02 23:30 ` Eric Dumazet
2014-09-03 2:46 ` Alexander Duyck
2014-09-03 4:23 ` Eric Dumazet
2014-09-03 11:57 ` Jesper Dangaard Brouer
2014-09-03 11:48 ` [net-next PATCH] qdisc: validate " Jesper Dangaard Brouer
2014-09-03 13:43 ` Eric Dumazet
2014-09-03 13:52 ` Jesper Dangaard Brouer [this message]
2014-09-03 14:26 ` Jesper Dangaard Brouer
2014-09-03 15:22 ` Eric Dumazet
2014-09-03 15:24 ` [net-next PATCH V2] " Jesper Dangaard Brouer
2014-09-03 15:56 ` [net-next PATCH V3] " Jesper Dangaard Brouer
2014-09-03 16:08 ` Eric Dumazet
2014-09-03 16:17 ` Jesper Dangaard Brouer
2014-09-04 3:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903155213.62ff4eff@redhat.com \
--to=brouer@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).