* [PATCH net-next] mlx4_en: Convert the normal skb free path to dev_consume_skb_any()
@ 2014-09-03 16:18 Rick Jones
2014-09-03 17:53 ` Eric Dumazet
2014-09-04 4:00 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Rick Jones @ 2014-09-03 16:18 UTC (permalink / raw)
To: netdev; +Cc: amirv, davem
From: Rick Jones <rick.jones2@hp.com>
It would appear the mlx4_en driver was still making a call to
dev_kfree_skb_any() where dev_consume_skb_any() would be more
appropriate. This should make dropped packet profiling/tracking
easier/better over a NIC driven by mlx4_en.
Signed-off-by: Rick Jones <rick.jones2@hp.com>
---
Compile tested only
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
index dae3da6..bc8f51c 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
@@ -319,7 +319,7 @@ static u32 mlx4_en_free_tx_desc(struct mlx4_en_priv *priv,
}
}
}
- dev_kfree_skb_any(skb);
+ dev_consume_skb_any(skb);
return tx_info->nr_txbb;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] mlx4_en: Convert the normal skb free path to dev_consume_skb_any()
2014-09-03 16:18 [PATCH net-next] mlx4_en: Convert the normal skb free path to dev_consume_skb_any() Rick Jones
@ 2014-09-03 17:53 ` Eric Dumazet
2014-09-04 4:00 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2014-09-03 17:53 UTC (permalink / raw)
To: Rick Jones; +Cc: netdev, amirv, davem
On Wed, 2014-09-03 at 09:18 -0700, Rick Jones wrote:
> From: Rick Jones <rick.jones2@hp.com>
>
> It would appear the mlx4_en driver was still making a call to
> dev_kfree_skb_any() where dev_consume_skb_any() would be more
> appropriate. This should make dropped packet profiling/tracking
> easier/better over a NIC driven by mlx4_en.
>
> Signed-off-by: Rick Jones <rick.jones2@hp.com>
>
> ---
>
> Compile tested only
>
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
> index dae3da6..bc8f51c 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
> @@ -319,7 +319,7 @@ static u32 mlx4_en_free_tx_desc(struct mlx4_en_priv *priv,
> }
> }
> }
> - dev_kfree_skb_any(skb);
> + dev_consume_skb_any(skb);
> return tx_info->nr_txbb;
> }
>
I use a similar patch here, I confirm this works.
Acked-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] mlx4_en: Convert the normal skb free path to dev_consume_skb_any()
2014-09-03 16:18 [PATCH net-next] mlx4_en: Convert the normal skb free path to dev_consume_skb_any() Rick Jones
2014-09-03 17:53 ` Eric Dumazet
@ 2014-09-04 4:00 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-09-04 4:00 UTC (permalink / raw)
To: raj; +Cc: netdev, amirv
From: raj@tardy.usa.hp.com (Rick Jones)
Date: Wed, 3 Sep 2014 09:18:00 -0700 (PDT)
> From: Rick Jones <rick.jones2@hp.com>
>
> It would appear the mlx4_en driver was still making a call to
> dev_kfree_skb_any() where dev_consume_skb_any() would be more
> appropriate. This should make dropped packet profiling/tracking
> easier/better over a NIC driven by mlx4_en.
>
> Signed-off-by: Rick Jones <rick.jones2@hp.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-04 3:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-03 16:18 [PATCH net-next] mlx4_en: Convert the normal skb free path to dev_consume_skb_any() Rick Jones
2014-09-03 17:53 ` Eric Dumazet
2014-09-04 4:00 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).