From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [net-next PATCH] qdisc: exit case fixes for skb list handling in qdisc layer Date: Thu, 4 Sep 2014 07:39:12 +0200 Message-ID: <20140904073912.6767fc20@redhat.com> References: <1409671557.3173.110.camel@edumazet-glaptop2.roam.corp.google.com> <20140903101250.7668.91659.stgit@dragon> <20140903.204256.1398300065789241714.davem@davemloft.net> <1409808259.26422.84.camel@edumazet-glaptop2.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: David Miller , netdev@vger.kernel.org, fw@strlen.de, hannes@stressinduktion.org, dborkman@redhat.com, brouer@redhat.com To: Eric Dumazet Return-path: Received: from mx1.redhat.com ([209.132.183.28]:12265 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751068AbaIDFj0 (ORCPT ); Thu, 4 Sep 2014 01:39:26 -0400 In-Reply-To: <1409808259.26422.84.camel@edumazet-glaptop2.roam.corp.google.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 03 Sep 2014 22:24:19 -0700 Eric Dumazet wrote: > On Wed, 2014-09-03 at 20:42 -0700, David Miller wrote: > > From: Jesper Dangaard Brouer > > Date: Wed, 03 Sep 2014 12:12:50 +0200 > > > > > More minor fixes to merge commit 53fda7f7f9e (Merge branch 'xmit_list') > > > that allows us to work with a list of SKBs. > > > > > > Fixing exit cases in qdisc_reset() and qdisc_destroy(), where a > > > leftover requeued SKB (qdisc->gso_skb) can have the potential of > > > being a skb list, thus use kfree_skb_list(). > > > > > > This is a followup to commit 10770bc2d1 ("qdisc: adjustments for > > > API allowing skb list xmits"). > > > > > > Signed-off-by: Jesper Dangaard Brouer > > > > Applied. > > Strange, I sent same patch a little earlier ;) Yes, very strange, especially as Dave also said he had applied your patch too (I did comment on your post, apologizing for not noticing your patch, before sending this one). -- Best regards, Jesper Dangaard Brouer MSc.CS, Sr. Network Kernel Developer at Red Hat Author of http://www.iptv-analyzer.org LinkedIn: http://www.linkedin.com/in/brouer