From: David Miller <davem@davemloft.net>
To: mugunthanvnm@ti.com
Cc: netdev@vger.kernel.org
Subject: Re: [net PATCH 1/1] drivers: net: cpsw: dual_emac: fix reducing of rx descriptor during ifdown
Date: Fri, 05 Sep 2014 14:29:17 -0700 (PDT) [thread overview]
Message-ID: <20140905.142917.1749731214890237469.davem@davemloft.net> (raw)
In-Reply-To: <5406C067.5080103@ti.com>
From: Mugunthan V N <mugunthanvnm@ti.com>
Date: Wed, 3 Sep 2014 12:46:55 +0530
> On Wednesday 03 September 2014 12:24 AM, David Miller wrote:
>> Also this doesn't explain why the "status < 0" case applies to this
>> new logic, you have not explained that at all.
>>
>
> This scenario is not generated when "status < 0", "status < 0" happens
> when DMA is in tear-down mode, the above scenario happens when
> netif_running(ndev) is false which denotes that netdev is down already.
Your condition was:
if (status < 0 || !netif_running(ndev))
so this "scenerio" is being handled when status < 0, which is what
I am objecting to.
prev parent reply other threads:[~2014-09-05 21:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 9:22 [net PATCH 1/1] drivers: net: cpsw: dual_emac: fix reducing of rx descriptor during ifdown Mugunthan V N
2014-09-02 1:31 ` David Miller
2014-09-02 9:21 ` Mugunthan V N
2014-09-02 18:54 ` David Miller
2014-09-03 7:16 ` Mugunthan V N
2014-09-03 17:07 ` Mugunthan V N
2014-09-05 21:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905.142917.1749731214890237469.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).