From: David Miller <davem@davemloft.net>
To: gang.chen.5i5j@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
michal.simek@xilinx.com, monstr@monstr.eu
Subject: Re: [PATCH] drivers/net/fddi/skfp/h/skfbi.h: Remove useless PCI_BASE_2ND macros
Date: Fri, 05 Sep 2014 14:52:10 -0700 (PDT) [thread overview]
Message-ID: <20140905.145210.1213133106797408601.davem@davemloft.net> (raw)
In-Reply-To: <54073322.6030508@gmail.com>
From: Chen Gang <gang.chen.5i5j@gmail.com>
Date: Wed, 03 Sep 2014 23:26:26 +0800
> They are use less, and may generate compiling warnings, so remove them
> (microblaze, arc, arm64, and unicore32 have already defined PCI_IOBASE).
>
> The related warnings (with allmodconfig under microblaze):
>
> CC [M] drivers/net/fddi/skfp/skfddi.o
> In file included from drivers/net/fddi/skfp/skfddi.c:95:0:
> drivers/net/fddi/skfp/h/skfbi.h:151:0: warning: "PCI_IOBASE" redefined
> #define PCI_IOBASE 0xffffff00L /* Bit 31..8: I/O Base address */
> ^
> In file included from include/linux/io.h:22:0,
> from include/linux/pci.h:31,
> from drivers/net/fddi/skfp/skfddi.c:82:
> ./arch/microblaze/include/asm/io.h:33:0: note: this is the location of the previous definition
> #define PCI_IOBASE ((void __iomem *)_IO_BASE)
> ^
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Applied, thanks.
prev parent reply other threads:[~2014-09-05 21:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 15:26 [PATCH] drivers/net/fddi/skfp/h/skfbi.h: Remove useless PCI_BASE_2ND macros Chen Gang
2014-09-05 21:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905.145210.1213133106797408601.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gang.chen.5i5j@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).