From: David Miller <davem@davemloft.net>
To: nicolas.dichtel@6wind.com
Cc: yoshfuji@linux-ipv6.org, netdev@vger.kernel.org
Subject: Re: [PATCH net 1/2] ipv6: fix a refcnt leak with peer addr
Date: Fri, 05 Sep 2014 17:13:47 -0700 (PDT) [thread overview]
Message-ID: <20140905.171347.1273847652821486122.davem@davemloft.net> (raw)
In-Reply-To: <1409781562-4191-1-git-send-email-nicolas.dichtel@6wind.com>
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Wed, 3 Sep 2014 23:59:21 +0200
> There is no reason to take a refcnt before deleting the peer address route.
> It's done some lines below for the local prefix route because
> inet6_ifa_finish_destroy() will release it at the end.
> For the peer address route, we want to free it right now.
>
> This bug has been introduced by commit
> caeaba79009c ("ipv6: add support of peer address").
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Applied.
prev parent reply other threads:[~2014-09-06 0:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 21:59 [PATCH net 1/2] ipv6: fix a refcnt leak with peer addr Nicolas Dichtel
2014-09-03 21:59 ` [PATCH net 2/2] ipv6: use addrconf_get_prefix_route() to remove " Nicolas Dichtel
2014-09-03 23:51 ` Hannes Frederic Sowa
2014-09-06 0:13 ` David Miller
2014-09-03 23:43 ` [PATCH net 1/2] ipv6: fix a refcnt leak with " Hannes Frederic Sowa
2014-09-06 0:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905.171347.1273847652821486122.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).