From: David Miller <davem@davemloft.net>
To: azhou@nicira.com
Cc: netdev@vger.kernel.org
Subject: Re: [net-next v4 0/3] Refactor vxlan and l2tp to use common UDP tunnel APIs
Date: Fri, 05 Sep 2014 17:19:42 -0700 (PDT) [thread overview]
Message-ID: <20140905.171942.713956165843587914.davem@davemloft.net> (raw)
In-Reply-To: <1409817462-7957-1-git-send-email-azhou@nicira.com>
From: Andy Zhou <azhou@nicira.com>
Date: Thu, 4 Sep 2014 00:57:39 -0700
> Andy Zhou (3):
> udp-tunnel: Expand UDP tunnel APIs
> vxlan: Refactor vxlan driver to make use of the common UDP tunnel
> functions.
> l2tp: Refactor l2tp core driver to make use of the common UDP tunnel
> functions
Way too many ifdefs in *.c code, and your indentation is not correct.
For function calls that span multiple lines, you must start the second
and subsequent lines exactly at the first column after the openning
parenthesis of the first line. You must use the appropriate number of
TAB and SPACE characters necessary to do so. If you are indenting these
lines only using TAB characters, you are very likely doing it wrong.
Thanks.
next parent reply other threads:[~2014-09-06 0:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1409817462-7957-1-git-send-email-azhou@nicira.com>
2014-09-06 0:19 ` David Miller [this message]
2014-09-09 7:49 ` [net-next v4 0/3] Refactor vxlan and l2tp to use common UDP tunnel APIs Andy Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905.171942.713956165843587914.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=azhou@nicira.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).