netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: netdev@vger.kernel.org, klassert@mathematik.tu-chemnitz.de
Subject: Re: [PATCH v3] 3c59x: avoid panic in boomerang_start_xmit when finding page address:
Date: Fri, 05 Sep 2014 17:24:26 -0700 (PDT)	[thread overview]
Message-ID: <20140905.172426.1277528296784403545.davem@davemloft.net> (raw)
In-Reply-To: <1409825618-30785-1-git-send-email-nhorman@tuxdriver.com>

From: Neil Horman <nhorman@tuxdriver.com>
Date: Thu,  4 Sep 2014 06:13:38 -0400

> This bug was reported on a very old kernel (RHEL6, 2.6.32-491.el6):
 ...
> But the problem seems to still exist upstream.  It seems on 32 bit kernels
> page_address() can reutrn a NULL value in some circumstances, and the
> pci_map_single api isn't prepared to handle that (on this system it results in a
> bogus pointer deference in nommu_map_page.
> 
> The fix is pretty easy, if we convert the 3c59x driver to use the more
> convieient skb_frag_dma_map api we don't need to find the virtual address of the
> page at all, and page gets mapped to the hardware properly.  Verified to fix the
> problem as described by the reporter.
> 
> Applies to the net tree
> 
> Change Notes:
> 
> v2) Converted PCI_DMA_TODEVICE to DMA_TO_DEVICE.  Thanks Dave!
> 
> v3) Actually Run git commit after making changes to v2 :)
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>

Applied, thanks Neil.

  parent reply	other threads:[~2014-09-06  0:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-02 16:51 [PATCH] 3c59x: avoid panic in boomerang_start_xmit when finding page address: Neil Horman
2014-09-02 21:08 ` David Miller
2014-09-03 10:17 ` [PATCH v2] " Neil Horman
2014-09-04  3:58   ` David Miller
     [not found]     ` <1409825618-30785-1-git-send-email-nhorman@tuxdriver.com>
2014-09-06  0:24       ` David Miller [this message]
2014-09-07 20:43         ` [PATCH v3] " Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140905.172426.1277528296784403545.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=klassert@mathematik.tu-chemnitz.de \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).