* [patch -next] hyperv: NULL dereference on error
@ 2014-09-04 11:11 Dan Carpenter
2014-09-06 0:29 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-09-04 11:11 UTC (permalink / raw)
To: K. Y. Srinivasan, Haiyang Zhang; +Cc: devel, kernel-janitors, netdev
We try to call free_netvsc_device(net_device) when "net_device" is NULL.
It leads to an Oops.
Fixes: f90251c8a6d0 ('hyperv: Increase the buffer length for netvsc_channel_cb()')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index 5b5644a..977984b 100644
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -1054,10 +1054,8 @@ int netvsc_device_add(struct hv_device *device, void *additional_info)
struct net_device *ndev;
net_device = alloc_net_device(device);
- if (!net_device) {
- ret = -ENOMEM;
- goto cleanup;
- }
+ if (!net_device)
+ return -ENOMEM;
net_device->ring_size = ring_size;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch -next] hyperv: NULL dereference on error
2014-09-04 11:11 [patch -next] hyperv: NULL dereference on error Dan Carpenter
@ 2014-09-06 0:29 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-09-06 0:29 UTC (permalink / raw)
To: dan.carpenter; +Cc: kys, haiyangz, devel, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 4 Sep 2014 14:11:23 +0300
> We try to call free_netvsc_device(net_device) when "net_device" is NULL.
> It leads to an Oops.
>
> Fixes: f90251c8a6d0 ('hyperv: Increase the buffer length for netvsc_channel_cb()')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-06 0:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-04 11:11 [patch -next] hyperv: NULL dereference on error Dan Carpenter
2014-09-06 0:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).