From: David Miller <davem@davemloft.net>
To: daniel@gaisler.com
Cc: netdev@vger.kernel.org, software@gaisler.com
Subject: Re: [PATCH] greth: moved TX ring cleaning to NAPI rx poll func
Date: Fri, 05 Sep 2014 21:57:35 -0700 (PDT) [thread overview]
Message-ID: <20140905.215735.435013223458340103.davem@davemloft.net> (raw)
In-Reply-To: <1409915628-5249-1-git-send-email-daniel@gaisler.com>
From: Daniel Hellstrom <daniel@gaisler.com>
Date: Fri, 5 Sep 2014 13:13:48 +0200
> This patch does not affect the 10/100 GRETH MAC.
>
> Before all GBit GRETH TX descriptor ring cleaning was done in
> start_xmit(), when descriptor list became full it activated
> TX interrupt to start the NAPI rx poll function to do TX ring
> cleaning.
>
> With this patch the TX descriptor ring is always cleaned from
> the NAPI rx poll function, triggered via TX or RX interrupt.
> Otherwise we could end up in TX frames being sent but not
> reported to the stack being sent. On the 10/100 GRETH this
> is not an issue since the SKB is copied&aligned into private
> buffers so that the SKB can be freed directly on start_xmit()
>
> Signed-off-by: Daniel Hellstrom <daniel@gaisler.com>
Applied, thanks.
prev parent reply other threads:[~2014-09-06 4:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 11:13 [PATCH] greth: moved TX ring cleaning to NAPI rx poll func Daniel Hellstrom
2014-09-06 4:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905.215735.435013223458340103.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel@gaisler.com \
--cc=netdev@vger.kernel.org \
--cc=software@gaisler.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).