From: David Miller <davem@davemloft.net>
To: b.galvani@gmail.com
Cc: f.fainelli@gmail.com, maxime.ripard@free-electrons.com,
arnd@arndb.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: mdio-sun4i: don't select REGULATOR
Date: Sun, 07 Sep 2014 16:12:30 -0700 (PDT) [thread overview]
Message-ID: <20140907.161230.1498704332590876012.davem@davemloft.net> (raw)
In-Reply-To: <1409956103-23473-1-git-send-email-b.galvani@gmail.com>
From: Beniamino Galvani <b.galvani@gmail.com>
Date: Sat, 6 Sep 2014 00:28:23 +0200
> The mdio-sun4i driver automatically selects REGULATOR and
> REGULATOR_FIXED_VOLTAGE because it uses the regulator API. But a
> driver selecting a subsystem increases the chance of generating
> circular Kconfig dependencies, especially when other drivers depend on
> the selected symbol.
>
> Since the regulator API functions are replaced with no-ops when
> REGULATOR is disabled, the driver can be built successfully even
> without regulator support and so those 'select' dependencies can be
> safely dropped.
>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
Applied to net-next, thanks.
prev parent reply other threads:[~2014-09-07 23:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 22:28 [PATCH] net: phy: mdio-sun4i: don't select REGULATOR Beniamino Galvani
2014-09-07 23:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140907.161230.1498704332590876012.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=b.galvani@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox