From: David Miller <davem@davemloft.net>
To: roy.qing.li@gmail.com
Cc: pshelar@nicira.com, netdev@vger.kernel.org
Subject: Re: [PATCH][net-next] openvswitch: change the data type of error status to atomic_long_t
Date: Sun, 07 Sep 2014 16:17:20 -0700 (PDT) [thread overview]
Message-ID: <20140907.161720.168413856991894569.davem@davemloft.net> (raw)
In-Reply-To: <CAJFZqHwK=5iXxBP+SgcLtub=HSkTt9Pd6LU2_Tjn9qTxbQd3SA@mail.gmail.com>
From: Li RongQing <roy.qing.li@gmail.com>
Date: Sun, 7 Sep 2014 17:24:11 +0800
> 2. I did not find that tx_dropped/tx_error/.. is protected by spin
> lock under net dir,
> sometime tx_dropped is atomic_long_t; sometime it is percpu variable;
> sometime it is
> u64,but does not need to protect.
If it is only modified in ->ndo_start_xmit() then it is protected by
the per-queue TX lock, as ->ndo_start_xmit() is always invoked with
it held (except in LLTX drivers of course).
next prev parent reply other threads:[~2014-09-07 23:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-06 11:06 [PATCH][net-next] openvswitch: change the data type of error status to atomic_long_t roy.qing.li
2014-09-07 3:44 ` Pravin Shelar
2014-09-07 9:24 ` Li RongQing
2014-09-07 23:17 ` David Miller [this message]
2014-09-08 11:23 ` Li RongQing
2014-09-08 22:21 ` Cong Wang
2014-09-08 22:26 ` Pravin Shelar
2014-09-09 0:29 ` Li RongQing
2014-09-09 18:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140907.161720.168413856991894569.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=roy.qing.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).