From: David Miller <davem@davemloft.net>
To: andriy.shevchenko@linux.intel.com
Cc: samuel@sortiz.org, netdev@vger.kernel.org,
sergei.shtylyov@cogentembedded.com
Subject: Re: [PATCH v2] irda: vlsi_ir: use %*ph specifier
Date: Mon, 08 Sep 2014 14:10:11 -0700 (PDT) [thread overview]
Message-ID: <20140908.141011.2272191414764801766.davem@davemloft.net> (raw)
In-Reply-To: <1410161923-24783-1-git-send-email-andriy.shevchenko@linux.intel.com>
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Mon, 8 Sep 2014 10:38:43 +0300
> Instead of looping in the code let's use kernel extension to dump small
> buffers.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Try again:
drivers/net/irda/vlsi_ir.c: In function ‘vlsi_proc_ring’:
drivers/net/irda/vlsi_ir.c:327:39: warning: comparison of distinct pointer types lacks a cast [enabled by default]
The types on each side of the min() expression are different, so the
compiler warns. You probably need to use min_t() or similar, and
carefuly examine the possible effects of signed overflow etc.
prev parent reply other threads:[~2014-09-08 21:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 7:38 [PATCH v2] irda: vlsi_ir: use %*ph specifier Andy Shevchenko
2014-09-08 21:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140908.141011.2272191414764801766.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).