From: David Miller <davem@davemloft.net>
To: nikolay@redhat.com
Cc: netdev@vger.kernel.org, hariprasad@chelsio.com,
vfalico@gmail.com, j.vosburgh@gmail.com, andy@greyhouse.net
Subject: Re: [PATCH net-next v2 0/7] bonding: get rid of bond->lock
Date: Tue, 09 Sep 2014 17:32:46 -0700 (PDT) [thread overview]
Message-ID: <20140909.173246.407169326340249072.davem@davemloft.net> (raw)
In-Reply-To: <1410297423-26624-1-git-send-email-nikolay@redhat.com>
From: Nikolay Aleksandrov <nikolay@redhat.com>
Date: Tue, 9 Sep 2014 23:16:56 +0200
> This patch-set removes the last users of bond->lock and converts the places
> that needed it for sync to use curr_slave_lock or RCU as appropriate.
> I've run this with lockdep and have stress-tested it via loading/unloading
> and enslaving/releasing in parallel while outputting bond's proc, I didn't
> see any issues. Please pay special attention to the procfs change, I've
> done about an hour of stress-testing on it and have checked that the event
> that causes the bonding to delete its proc entry (NETDEV_UNREGISTER) is
> called before ndo_uninit() and the freeing of the dev so any readers will
> sync with that. Also ran sparse checks and there were no splats.
>
> v2: Add patch 0001/cxgb4 bond->lock removal, RTNL should be held in the
> notifier call, the other patches are the same. Also tested with
> allmodconfig to make sure there're no more users of bond->lock.
> Changes from the RFC:
> use RCU in procfs instead of RTNL since RTNL might lead to a deadlock with
> unloading and also is much slower. The bond destruction syncs with proc
> via the proc locks. There's one new patch that converts primary_slave to
> use RCU as it was necessary to fix a longstanding bugs in sysfs and
> procfs and to make it easy to migrate bond's procfs to RCU. And of course
> rebased on top of net-next current.
>
> This is the first patch-set in a series that should simplify the bond's
> locking requirements and will make it easier to define the locking
> conditions necessary for the various paths. The goal is to rely on RTNL
> and rcu alone, an extra lock would be needed in a few special cases that
> would be documented very well.
Series applied, thanks.
prev parent reply other threads:[~2014-09-10 0:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 21:16 [PATCH net-next v2 0/7] bonding: get rid of bond->lock Nikolay Aleksandrov
2014-09-09 21:16 ` [PATCH net-next v2 1/7] cxgb4: remove bond->lock Nikolay Aleksandrov
2014-09-09 21:16 ` [PATCH net-next v2 2/7] bonding: 3ad: use curr_slave_lock instead of bond->lock Nikolay Aleksandrov
2014-09-09 21:16 ` [PATCH net-next v2 3/7] bonding: alb: clean bond->lock Nikolay Aleksandrov
2014-09-09 21:17 ` [PATCH net-next v2 4/7] bonding: convert primary_slave to use RCU Nikolay Aleksandrov
2014-09-09 21:17 ` [PATCH net-next v2 5/7] bonding: procfs: clean bond->lock usage and " Nikolay Aleksandrov
2014-09-09 21:17 ` [PATCH net-next v2 6/7] bonding: options: remove bond->lock usage Nikolay Aleksandrov
2014-09-09 21:17 ` [PATCH net-next v2 7/7] bonding: remove last users of bond->lock and bond->lock itself Nikolay Aleksandrov
2014-09-10 0:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909.173246.407169326340249072.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=hariprasad@chelsio.com \
--cc=j.vosburgh@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).