From: David Miller <davem@davemloft.net>
To: ani@arista.com
Cc: fruggeri@arista.com, netdev@vger.kernel.org, fenner@arista.com,
travisb@arista.com, hannes@stressinduktion.org,
matthew.leach@arm.com, eric.dumazet@gmail.com
Subject: Re: [PATCH 1/1] net:socket: set msg_namelen to 0 if msg_name is passed as NULL in msghdr struct from userland.
Date: Tue, 09 Sep 2014 17:36:07 -0700 (PDT) [thread overview]
Message-ID: <20140909.173607.2092550389439938050.davem@davemloft.net> (raw)
In-Reply-To: <1410212999-11013-1-git-send-email-ani@arista.com>
From: Ani Sinha <ani@arista.com>
Date: Mon, 8 Sep 2014 14:49:59 -0700
> Linux manpage for recvmsg and sendmsg calls does not explicitly mention setting msg_namelen to 0 when
> msg_name passed set as NULL. When developers don't set msg_namelen member in msghdr, it might contain garbage
> value which will fail the validation check and sendmsg and recvmsg calls from kernel will return EINVAL. This will
> break old binaries and any code for which there is no access to source code.
> To fix this, we set msg_namelen to 0 when msg_name is passed as NULL from userland.
>
> Signed-off-by: Ani Sinha <ani@arista.com>
Applied, thanks.
prev parent reply other threads:[~2014-09-10 0:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 21:49 [PATCH 1/1] net:socket: set msg_namelen to 0 if msg_name is passed as NULL in msghdr struct from userland Ani Sinha
2014-09-09 22:14 ` Ani Sinha
2014-09-10 0:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909.173607.2092550389439938050.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ani@arista.com \
--cc=eric.dumazet@gmail.com \
--cc=fenner@arista.com \
--cc=fruggeri@arista.com \
--cc=hannes@stressinduktion.org \
--cc=matthew.leach@arm.com \
--cc=netdev@vger.kernel.org \
--cc=travisb@arista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).