* [PATCH v3] irda: vlsi_ir: use %*ph specifier
@ 2014-09-09 8:48 Andy Shevchenko
2014-09-10 3:11 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2014-09-09 8:48 UTC (permalink / raw)
To: netdev, Sergei Shtylyov, David Miller; +Cc: Andy Shevchenko
Instead of looping in the code let's use kernel extension to dump small
buffers.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/net/irda/vlsi_ir.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/irda/vlsi_ir.c b/drivers/net/irda/vlsi_ir.c
index a04af9d..a2e5561 100644
--- a/drivers/net/irda/vlsi_ir.c
+++ b/drivers/net/irda/vlsi_ir.c
@@ -324,12 +324,8 @@ static void vlsi_proc_ring(struct seq_file *seq, struct vlsi_ring *r)
seq_printf(seq, "current: rd = %d / status = %02x / len = %u\n",
h, (unsigned)rd_get_status(rd), j);
if (j > 0) {
- seq_printf(seq, " data:");
- if (j > 20)
- j = 20;
- for (i = 0; i < j; i++)
- seq_printf(seq, " %02x", (unsigned)((unsigned char *)rd->buf)[i]);
- seq_printf(seq, "\n");
+ seq_printf(seq, " data: %*ph\n",
+ min_t(unsigned, j, 20), rd->buf);
}
}
for (i = 0; i < r->size; i++) {
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] irda: vlsi_ir: use %*ph specifier
2014-09-09 8:48 [PATCH v3] irda: vlsi_ir: use %*ph specifier Andy Shevchenko
@ 2014-09-10 3:11 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-09-10 3:11 UTC (permalink / raw)
To: andriy.shevchenko; +Cc: netdev, sergei.shtylyov
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Tue, 9 Sep 2014 11:48:29 +0300
> Instead of looping in the code let's use kernel extension to dump small
> buffers.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-10 3:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-09 8:48 [PATCH v3] irda: vlsi_ir: use %*ph specifier Andy Shevchenko
2014-09-10 3:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).