* [PATCH net-next] ipv4: udp4_gro_complete() is static
@ 2014-09-09 15:29 Eric Dumazet
2014-09-09 18:30 ` Tom Herbert
2014-09-10 3:15 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Eric Dumazet @ 2014-09-09 15:29 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Tom Herbert
From: Eric Dumazet <edumazet@google.com>
net/ipv4/udp_offload.c:339:5: warning: symbol 'udp4_gro_complete' was
not declared. Should it be static?
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Tom Herbert <therbert@google.com>
Fixes: 57c67ff4bd92 ("udp: additional GRO support")
---
net/ipv4/udp_offload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/udp_offload.c b/net/ipv4/udp_offload.c
index 84e0e05c9c0e..52d5f46abf86 100644
--- a/net/ipv4/udp_offload.c
+++ b/net/ipv4/udp_offload.c
@@ -336,7 +336,7 @@ int udp_gro_complete(struct sk_buff *skb, int nhoff)
return err;
}
-int udp4_gro_complete(struct sk_buff *skb, int nhoff)
+static int udp4_gro_complete(struct sk_buff *skb, int nhoff)
{
const struct iphdr *iph = ip_hdr(skb);
struct udphdr *uh = (struct udphdr *)(skb->data + nhoff);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] ipv4: udp4_gro_complete() is static
2014-09-09 15:29 [PATCH net-next] ipv4: udp4_gro_complete() is static Eric Dumazet
@ 2014-09-09 18:30 ` Tom Herbert
2014-09-10 3:15 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Tom Herbert @ 2014-09-09 18:30 UTC (permalink / raw)
To: Eric Dumazet; +Cc: David Miller, netdev
On Tue, Sep 9, 2014 at 8:29 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> net/ipv4/udp_offload.c:339:5: warning: symbol 'udp4_gro_complete' was
> not declared. Should it be static?
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Tom Herbert <therbert@google.com>
> Fixes: 57c67ff4bd92 ("udp: additional GRO support")
> ---
> net/ipv4/udp_offload.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv4/udp_offload.c b/net/ipv4/udp_offload.c
> index 84e0e05c9c0e..52d5f46abf86 100644
> --- a/net/ipv4/udp_offload.c
> +++ b/net/ipv4/udp_offload.c
> @@ -336,7 +336,7 @@ int udp_gro_complete(struct sk_buff *skb, int nhoff)
> return err;
> }
>
> -int udp4_gro_complete(struct sk_buff *skb, int nhoff)
> +static int udp4_gro_complete(struct sk_buff *skb, int nhoff)
> {
> const struct iphdr *iph = ip_hdr(skb);
> struct udphdr *uh = (struct udphdr *)(skb->data + nhoff);
>
>
Acked-by: Tom Herbert <therbert@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] ipv4: udp4_gro_complete() is static
2014-09-09 15:29 [PATCH net-next] ipv4: udp4_gro_complete() is static Eric Dumazet
2014-09-09 18:30 ` Tom Herbert
@ 2014-09-10 3:15 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-09-10 3:15 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, therbert
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 09 Sep 2014 08:29:12 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> net/ipv4/udp_offload.c:339:5: warning: symbol 'udp4_gro_complete' was
> not declared. Should it be static?
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Tom Herbert <therbert@google.com>
> Fixes: 57c67ff4bd92 ("udp: additional GRO support")
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-10 3:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-09 15:29 [PATCH net-next] ipv4: udp4_gro_complete() is static Eric Dumazet
2014-09-09 18:30 ` Tom Herbert
2014-09-10 3:15 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).