From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] drivers/net: Convert remaining uses of pr_warning to pr_warn
Date: Tue, 09 Sep 2014 20:37:32 -0700 (PDT) [thread overview]
Message-ID: <20140909.203732.1451216065011764152.davem@davemloft.net> (raw)
In-Reply-To: <1410319664.24028.6.camel@joe-AO725>
From: Joe Perches <joe@perches.com>
Date: Tue, 09 Sep 2014 20:27:44 -0700
> Use the much more common pr_warn instead of pr_warning.
>
> Other miscellanea:
>
> o Typo fixes submiting/submitting
> o Coalesce formats
> o Realign arguments
> o Add missing terminating '\n' to formats
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>
> Most of these are old drivers so I'm not cc'ing everyone.
> Let me know if you want these separated or simply dropped.
>
> This does add a long line for a coalesced variable.
> I think it reads better whole than in pieces.
Applied, thanks.
prev parent reply other threads:[~2014-09-10 3:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 3:27 [PATCH net-next] drivers/net: Convert remaining uses of pr_warning to pr_warn Joe Perches
2014-09-10 3:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909.203732.1451216065011764152.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).