From: David Miller <davem@davemloft.net>
To: therbert@google.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/3] net: enable GRO for IPIP and SIT
Date: Tue, 09 Sep 2014 21:32:05 -0700 (PDT) [thread overview]
Message-ID: <20140909.213205.2150566517395290798.davem@davemloft.net> (raw)
In-Reply-To: <CA+mtBx_1VWkzU3EcyR=o45CWGevhGdiJiKH-z5Kc7qzqyNkC9Q@mail.gmail.com>
From: Tom Herbert <therbert@google.com>
Date: Tue, 9 Sep 2014 21:04:27 -0700
> On Tue, Sep 9, 2014 at 8:27 PM, David Miller <davem@davemloft.net> wrote:
>> From: Tom Herbert <therbert@google.com>
>> Date: Tue, 9 Sep 2014 11:23:13 -0700
>>
>>> This patch sets populates the IPIP and SIT offload structures with
>>> gro_receive and gro_complete functions. This enables use of GRO
>>> for these. Also, fixed a problem in IPv6 where we were not properly
>>> initializing flush_id.
>>
>> We're going to need to sort this out, because these functions are
>> now static after Eric's patches to fix sparse warnings.
>>
>> You're going to have to respin this with that patch you intended
>> to add from the previous series that exported these routines.
>
> I might be missing something, but I believe the functions referred in
> this patch series were already static.
Oops my bad, let me rereview this...
Yep it's fine, applied, thanks!
prev parent reply other threads:[~2014-09-10 4:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 18:23 [PATCH net-next 0/3] net: enable GRO for IPIP and SIT Tom Herbert
2014-09-09 18:23 ` [PATCH net-next 1/3] ipv6: Clear flush_id to make GRO work Tom Herbert
2014-09-09 18:38 ` Eric Dumazet
2014-09-09 18:52 ` Tom Herbert
2014-09-09 18:23 ` [PATCH 2/3] ipip: Add gro callbacks to ipip offload Tom Herbert
2014-09-09 18:23 ` [PATCH 3/3] sit: Add gro callbacks to sit_offload Tom Herbert
2014-09-10 3:27 ` [PATCH net-next 0/3] net: enable GRO for IPIP and SIT David Miller
2014-09-10 4:04 ` Tom Herbert
2014-09-10 4:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909.213205.2150566517395290798.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).