From: David Miller <davem@davemloft.net>
To: cwang@twopensource.com
Cc: sd@queasysnail.net, netdev@vger.kernel.org, hannes@stressinduktion.org
Subject: Re: [PATCH net] ipv6: clean up anycast when an interface is destroyed
Date: Wed, 10 Sep 2014 13:58:40 -0700 (PDT) [thread overview]
Message-ID: <20140910.135840.133555874665251669.davem@davemloft.net> (raw)
In-Reply-To: <CAHA+R7ODewXP69ULsR0RD+c3BEfMa90zATRjHF3dC9Dkv7jgZw@mail.gmail.com>
From: Cong Wang <cwang@twopensource.com>
Date: Wed, 10 Sep 2014 10:15:01 -0700
> On Wed, Sep 10, 2014 at 3:27 AM, Sabrina Dubroca <sd@queasysnail.net> wrote:
>> diff --git a/net/ipv6/anycast.c b/net/ipv6/anycast.c
>> index ff2de7d9d8e6..a1bf80574bfe 100644
>> --- a/net/ipv6/anycast.c
>> +++ b/net/ipv6/anycast.c
>> @@ -351,6 +351,28 @@ static int ipv6_dev_ac_dec(struct net_device *dev, const struct in6_addr *addr)
>> return __ipv6_dev_ac_dec(idev, addr);
>> }
>>
>> +/* Device is being destroyed: clean up */
>
> This comment is useless.
Agreed, please remove this and respin that patch.
Thanks.
next prev parent reply other threads:[~2014-09-10 20:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 10:27 [PATCH net] ipv6: clean up anycast when an interface is destroyed Sabrina Dubroca
2014-09-10 17:15 ` Cong Wang
2014-09-10 20:58 ` David Miller [this message]
2014-09-10 21:23 ` [PATCH v2 " Sabrina Dubroca
2014-09-12 19:45 ` Hannes Frederic Sowa
2014-09-12 21:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910.135840.133555874665251669.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cwang@twopensource.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).