* [PATCH] net: axienet: remove unnecessary ether_setup after alloc_etherdev
@ 2014-09-11 9:23 Subbaraya Sundeep Bhatta
2014-09-12 22:16 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Subbaraya Sundeep Bhatta @ 2014-09-11 9:23 UTC (permalink / raw)
To: davem, jeffrey.t.kirsher, jesse.brandeburg, netdev, linux-kernel
Cc: michals, svemula, anirudh, Subbaraya Sundeep Bhatta
calling ether_setup is redundant since alloc_etherdev calls
it.
Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
---
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index c8fd941..4ea2d4e 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -1485,7 +1485,6 @@ static int axienet_of_probe(struct platform_device *op)
if (!ndev)
return -ENOMEM;
- ether_setup(ndev);
platform_set_drvdata(op, ndev);
SET_NETDEV_DEV(ndev, &op->dev);
--
1.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: axienet: remove unnecessary ether_setup after alloc_etherdev
2014-09-11 9:23 [PATCH] net: axienet: remove unnecessary ether_setup after alloc_etherdev Subbaraya Sundeep Bhatta
@ 2014-09-12 22:16 ` David Miller
2014-09-14 8:30 ` sundeep subbaraya
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2014-09-12 22:16 UTC (permalink / raw)
To: subbaraya.sundeep.bhatta
Cc: jeffrey.t.kirsher, jesse.brandeburg, netdev, linux-kernel,
michals, svemula, anirudh, sbhatta
From: Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@xilinx.com>
Date: Thu, 11 Sep 2014 14:53:33 +0530
> calling ether_setup is redundant since alloc_etherdev calls
> it.
>
> Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: axienet: remove unnecessary ether_setup after alloc_etherdev
2014-09-12 22:16 ` David Miller
@ 2014-09-14 8:30 ` sundeep subbaraya
0 siblings, 0 replies; 3+ messages in thread
From: sundeep subbaraya @ 2014-09-14 8:30 UTC (permalink / raw)
To: David Miller
Cc: Subbaraya Sundeep Bhatta, jeffrey.t.kirsher, jesse.brandeburg,
netdev, linux-kernel@vger.kernel.org, Michal Simek, svemula,
anirudh, Subbaraya Sundeep Bhatta
Thanks David,
Sundeep.
On Sat, Sep 13, 2014 at 3:46 AM, David Miller <davem@davemloft.net> wrote:
> From: Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@xilinx.com>
> Date: Thu, 11 Sep 2014 14:53:33 +0530
>
>> calling ether_setup is redundant since alloc_etherdev calls
>> it.
>>
>> Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
>
> Applied.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-14 8:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-11 9:23 [PATCH] net: axienet: remove unnecessary ether_setup after alloc_etherdev Subbaraya Sundeep Bhatta
2014-09-12 22:16 ` David Miller
2014-09-14 8:30 ` sundeep subbaraya
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).