From: David Miller <davem@davemloft.net>
To: alexandre.belloni@free-electrons.com
Cc: nicolas.ferre@atmel.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
voice.shen@atmel.com
Subject: Re: [PATCH] net/macb: Add hardware revision information during probe
Date: Fri, 12 Sep 2014 18:20:52 -0400 (EDT) [thread overview]
Message-ID: <20140912.182052.1655150437302824636.davem@davemloft.net> (raw)
In-Reply-To: <1410447096-29980-1-git-send-email-alexandre.belloni@free-electrons.com>
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Date: Thu, 11 Sep 2014 16:51:36 +0200
> From: Bo Shen <voice.shen@atmel.com>
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> drivers/net/ethernet/cadence/macb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index ca5d7798b265..a3b35c146d9c 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -2241,6 +2241,7 @@ static int __init macb_probe(struct platform_device *pdev)
>
> netif_carrier_off(dev);
>
> + netdev_info(dev, "Cadence rev 0x%08x\n", macb_readl(bp, MID));
> netdev_info(dev, "Cadence %s at 0x%08lx irq %d (%pM)\n",
> macb_is_gem(bp) ? "GEM" : "MACB", dev->base_addr,
> dev->irq, dev->dev_addr);
This is really sloppy. The "Cadence %s at ..." is what announces the device,
therefore it's out of context to print out the device revision beforehand.
Why don't you just add it to the existing printout instead?
prev parent reply other threads:[~2014-09-12 22:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 14:51 [PATCH] net/macb: Add hardware revision information during probe Alexandre Belloni
2014-09-12 22:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140912.182052.1655150437302824636.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).