* [PATCH] net/macb: Add hardware revision information during probe
@ 2014-09-11 14:51 Alexandre Belloni
2014-09-12 22:20 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Belloni @ 2014-09-11 14:51 UTC (permalink / raw)
To: Nicolas Ferre; +Cc: linux-arm-kernel, linux-kernel, netdev, Bo Shen
From: Bo Shen <voice.shen@atmel.com>
Signed-off-by: Bo Shen <voice.shen@atmel.com>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
drivers/net/ethernet/cadence/macb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index ca5d7798b265..a3b35c146d9c 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -2241,6 +2241,7 @@ static int __init macb_probe(struct platform_device *pdev)
netif_carrier_off(dev);
+ netdev_info(dev, "Cadence rev 0x%08x\n", macb_readl(bp, MID));
netdev_info(dev, "Cadence %s at 0x%08lx irq %d (%pM)\n",
macb_is_gem(bp) ? "GEM" : "MACB", dev->base_addr,
dev->irq, dev->dev_addr);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/macb: Add hardware revision information during probe
2014-09-11 14:51 [PATCH] net/macb: Add hardware revision information during probe Alexandre Belloni
@ 2014-09-12 22:20 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-09-12 22:20 UTC (permalink / raw)
To: alexandre.belloni
Cc: nicolas.ferre, linux-arm-kernel, linux-kernel, netdev, voice.shen
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Date: Thu, 11 Sep 2014 16:51:36 +0200
> From: Bo Shen <voice.shen@atmel.com>
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> drivers/net/ethernet/cadence/macb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index ca5d7798b265..a3b35c146d9c 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -2241,6 +2241,7 @@ static int __init macb_probe(struct platform_device *pdev)
>
> netif_carrier_off(dev);
>
> + netdev_info(dev, "Cadence rev 0x%08x\n", macb_readl(bp, MID));
> netdev_info(dev, "Cadence %s at 0x%08lx irq %d (%pM)\n",
> macb_is_gem(bp) ? "GEM" : "MACB", dev->base_addr,
> dev->irq, dev->dev_addr);
This is really sloppy. The "Cadence %s at ..." is what announces the device,
therefore it's out of context to print out the device revision beforehand.
Why don't you just add it to the existing printout instead?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-12 22:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-11 14:51 [PATCH] net/macb: Add hardware revision information during probe Alexandre Belloni
2014-09-12 22:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).