From: David Miller <davem@davemloft.net>
To: therbert@google.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next 3/7] fou: Add GRO support
Date: Mon, 15 Sep 2014 14:22:27 -0400 (EDT) [thread overview]
Message-ID: <20140915.142227.385081853295017602.davem@davemloft.net> (raw)
In-Reply-To: <1410750483-3236-4-git-send-email-therbert@google.com>
From: Tom Herbert <therbert@google.com>
Date: Sun, 14 Sep 2014 20:07:59 -0700
> @@ -62,6 +64,70 @@ static int fou_udp_recv(struct sock *sk, struct sk_buff *skb)
> sizeof(struct udphdr));
> }
>
> +static inline struct sk_buff **fou_gro_receive(struct sk_buff **head,
> + struct sk_buff *skb,
> + const struct net_offload
> + **offloads)
Please drop the "inline" in foo.c files and let the compiler decide. And
then you won't need to split up the "offloads" variable declaration like
that.
next prev parent reply other threads:[~2014-09-15 18:22 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 3:07 [PATCH v2 net-next 0/7] net: foo-over-udp (fou) Tom Herbert
2014-09-15 3:07 ` [PATCH v2 net-next 1/7] net: Export inet_offloads and inet6_offloads Tom Herbert
2014-09-15 13:33 ` Or Gerlitz
2014-09-15 15:13 ` Tom Herbert
2014-09-15 17:15 ` Or Gerlitz
2014-09-15 17:32 ` Tom Herbert
2014-09-15 18:21 ` David Miller
2014-09-15 3:07 ` [PATCH v2 net-next 2/7] fou: Support for foo-over-udp RX path Tom Herbert
2014-09-15 3:07 ` [PATCH v2 net-next 3/7] fou: Add GRO support Tom Herbert
2014-09-15 15:00 ` Or Gerlitz
2014-09-15 15:10 ` Tom Herbert
2014-09-15 17:03 ` Or Gerlitz
2014-09-15 17:21 ` Tom Herbert
2014-09-15 18:22 ` David Miller [this message]
2014-09-15 3:08 ` [PATCH v2 net-next 4/7] net: Changes to ip_tunnel to support foo-over-udp encapsulation Tom Herbert
2014-09-15 3:08 ` [PATCH v2 net-next 5/7] sit: TX path for sit/UDP " Tom Herbert
2014-09-15 3:08 ` [PATCH v2 net-next 6/7] ipip: TX path for IPIP/UDP " Tom Herbert
2014-09-15 3:08 ` [PATCH v2 net-next 7/7] gre: TX path for GRE/UDP " Tom Herbert
2014-09-15 18:08 ` [PATCH v2 net-next 0/7] net: foo-over-udp (fou) Or Gerlitz
2014-09-15 19:15 ` Tom Herbert
2014-09-15 22:44 ` Jesse Gross
2014-09-15 22:59 ` Tom Herbert
2014-09-16 0:15 ` Jesse Gross
2014-09-16 12:44 ` Or Gerlitz
2014-09-16 18:34 ` Tom Herbert
2014-09-16 19:14 ` Or Gerlitz
2014-09-16 20:31 ` Tom Herbert
2014-09-16 13:35 ` Or Gerlitz
2014-09-16 15:00 ` Tom Herbert
2014-09-16 20:04 ` Or Gerlitz
2014-09-16 20:16 ` David Miller
2014-09-17 15:22 ` Or Gerlitz
2014-09-16 20:35 ` Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915.142227.385081853295017602.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).