From: David Miller <davem@davemloft.net>
To: Frank.Li@freescale.com
Cc: b38611@freescale.com, netdev@vger.kernel.org, lznuaa@gmail.com,
shawn.guo@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [Patch net-next 1/4] net: fec: refine error handle of parser queue number from DT
Date: Mon, 15 Sep 2014 17:32:47 -0400 (EDT) [thread overview]
Message-ID: <20140915.173247.59215420475562894.davem@davemloft.net> (raw)
In-Reply-To: <1410801177-15872-2-git-send-email-Frank.Li@freescale.com>
From: <Frank.Li@freescale.com>
Date: Tue, 16 Sep 2014 01:12:54 +0800
> - dev_err(&pdev->dev, "Invalidate num_tx(=%d), fail back to 1\n",
> + dev_warn(&pdev->dev, "Invalid num_tx(=%d), fall back to 1\n",
> *num_tx);
Any time you change the function name of a multi-line function call, you must
be mindful to adjust the indention of the subsequent argument lines, if
necessary.
> if (*num_rx < 1 || *num_rx > FEC_ENET_MAX_RX_QS) {
> - dev_err(&pdev->dev, "Invalidate num_rx(=%d), fail back to 1\n",
> + dev_warn(&pdev->dev, "Invalid num_rx(=%d), fall back to 1\n",
> *num_rx);
Likewise.
next prev parent reply other threads:[~2014-09-15 21:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 17:12 [Patch net-next 0/4] net: fec: add interrupt coalescence Frank.Li
2014-09-15 17:12 ` [Patch net-next 1/4] net: fec: refine error handle of parser queue number from DT Frank.Li
2014-09-15 21:32 ` David Miller [this message]
2014-09-15 17:12 ` [Patch net-next 2/4] net: fec: add interrupt coalescence feature support Frank.Li
2014-09-15 21:34 ` David Miller
2014-09-15 17:12 ` [Patch net-next 3/4] net:fec: increase DMA queue number Frank.Li
2014-09-15 17:12 ` [Patch net-next 4/4] net: fec: Workaround for imx6sx enet tx hang when enable three queues Frank.Li
2014-09-15 21:35 ` David Miller
2014-09-16 0:52 ` Shawn Guo
2014-09-16 3:09 ` fugang.duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915.173247.59215420475562894.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Frank.Li@freescale.com \
--cc=b38611@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lznuaa@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).