* [Patch net-next] net_sched: fix suspicious RCU usage in cls_bpf_classify()
@ 2014-09-15 21:21 Cong Wang
2014-09-15 21:30 ` John Fastabend
2014-09-15 21:43 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Cong Wang @ 2014-09-15 21:21 UTC (permalink / raw)
To: netdev; +Cc: john.fastabend, David S. Miller, Cong Wang
Fixes: commit 1f947bf151e90ec0baad2948 ("net: sched: rcu'ify cls_bpf")
Cc: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
---
net/sched/cls_bpf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/cls_bpf.c b/net/sched/cls_bpf.c
index 6a7386e..4e3f5bf 100644
--- a/net/sched/cls_bpf.c
+++ b/net/sched/cls_bpf.c
@@ -52,7 +52,7 @@ static const struct nla_policy bpf_policy[TCA_BPF_MAX + 1] = {
static int cls_bpf_classify(struct sk_buff *skb, const struct tcf_proto *tp,
struct tcf_result *res)
{
- struct cls_bpf_head *head = rcu_dereference(tp->root);
+ struct cls_bpf_head *head = rcu_dereference_bh(tp->root);
struct cls_bpf_prog *prog;
int ret;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch net-next] net_sched: fix suspicious RCU usage in cls_bpf_classify()
2014-09-15 21:21 [Patch net-next] net_sched: fix suspicious RCU usage in cls_bpf_classify() Cong Wang
@ 2014-09-15 21:30 ` John Fastabend
2014-09-15 21:43 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: John Fastabend @ 2014-09-15 21:30 UTC (permalink / raw)
To: Cong Wang, netdev; +Cc: john.fastabend, David S. Miller
On 09/15/2014 02:21 PM, Cong Wang wrote:
> Fixes: commit 1f947bf151e90ec0baad2948 ("net: sched: rcu'ify cls_bpf")
> Cc: John Fastabend <john.fastabend@gmail.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> ---
> net/sched/cls_bpf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sched/cls_bpf.c b/net/sched/cls_bpf.c
> index 6a7386e..4e3f5bf 100644
> --- a/net/sched/cls_bpf.c
> +++ b/net/sched/cls_bpf.c
> @@ -52,7 +52,7 @@ static const struct nla_policy bpf_policy[TCA_BPF_MAX + 1] = {
> static int cls_bpf_classify(struct sk_buff *skb, const struct tcf_proto *tp,
> struct tcf_result *res)
> {
> - struct cls_bpf_head *head = rcu_dereference(tp->root);
> + struct cls_bpf_head *head = rcu_dereference_bh(tp->root);
> struct cls_bpf_prog *prog;
> int ret;
>
>
you beat me to it.
Acked-by: John Fastabend <john.r.fastabend@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch net-next] net_sched: fix suspicious RCU usage in cls_bpf_classify()
2014-09-15 21:21 [Patch net-next] net_sched: fix suspicious RCU usage in cls_bpf_classify() Cong Wang
2014-09-15 21:30 ` John Fastabend
@ 2014-09-15 21:43 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-09-15 21:43 UTC (permalink / raw)
To: xiyou.wangcong; +Cc: netdev, john.fastabend
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Mon, 15 Sep 2014 14:21:50 -0700
> Fixes: commit 1f947bf151e90ec0baad2948 ("net: sched: rcu'ify cls_bpf")
> Cc: John Fastabend <john.fastabend@gmail.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-15 21:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-15 21:21 [Patch net-next] net_sched: fix suspicious RCU usage in cls_bpf_classify() Cong Wang
2014-09-15 21:30 ` John Fastabend
2014-09-15 21:43 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).