From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= Subject: Re: [Patch v4 net-next 04/12] net: fec: parser max queue number from dt file Date: Mon, 15 Sep 2014 17:08:04 +0200 Message-ID: <20140915170804.39061c0d@ipc1.ka-ro> References: <1410555657-10744-1-git-send-email-Frank.Li@freescale.com> <1410555657-10744-5-git-send-email-Frank.Li@freescale.com> <20140915093926.11bdbc32@ipc1.ka-ro> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "Frank.Li@freescale.com" , Duan Fugang-B38611 , David Miller , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , Russell King - ARM Linux , Shawn Guo , "linux-arm-kernel@lists.infradead.org" To: Zhi Li Return-path: Received: from mail.karo-electronics.de ([81.173.242.67]:56463 "EHLO mail.karo-electronics.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752520AbaIOPIP convert rfc822-to-8bit (ORCPT ); Mon, 15 Sep 2014 11:08:15 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Hi, Zhi Li wrote: > On Mon, Sep 15, 2014 at 2:39 AM, Lothar Wa=C3=9Fmann wrote: > > Hi, > > > > Frank.Li@freescale.com wrote: > >> From: Fugang Duan > >> > >> By default, the tx/rx queue number is 1, user can config the queue= number > >> at DTS file like this: > >> fsl,num-tx-queues=3D<3>; > >> fsl,num-rx-queues=3D<3> > >> > >> Since i.MX6SX enet-AVB IP support multi queues, so use multi queue= s > >> interface to allocate and set up an Ethernet device. > >> > >> Signed-off-by: Fugang Duan > >> Signed-off-by: Frank Li > >> --- > >> drivers/net/ethernet/freescale/fec.h | 2 ++ > >> drivers/net/ethernet/freescale/fec_main.c | 46 ++++++++++++++++++= ++++++++++++- > >> 2 files changed, 47 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/et= hernet/freescale/fec.h > >> index b2b91f8..72fb90f 100644 > >> --- a/drivers/net/ethernet/freescale/fec.h > >> +++ b/drivers/net/ethernet/freescale/fec.h > >> @@ -356,6 +356,8 @@ struct fec_enet_private { > >> > >> bool ptp_clk_on; > >> struct mutex ptp_clk_mutex; > >> + unsigned int num_tx_queues; > >> + unsigned int num_rx_queues; > >> > >> /* The saved address of a sent-in-place packet/buffer, for s= kfree(). */ > >> struct fec_enet_priv_tx_q *tx_queue[FEC_ENET_MAX_TX_QS]; > >> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/n= et/ethernet/freescale/fec_main.c > >> index 4c0d2ee..2240df0 100644 > >> --- a/drivers/net/ethernet/freescale/fec_main.c > >> +++ b/drivers/net/ethernet/freescale/fec_main.c > >> @@ -2709,6 +2709,42 @@ static void fec_reset_phy(struct platform_d= evice *pdev) > >> } > >> #endif /* CONFIG_OF */ > >> > >> +static void > >> +fec_enet_get_queue_num(struct platform_device *pdev, int *num_tx,= int *num_rx) > >> +{ > >> + struct device_node *np =3D pdev->dev.of_node; > >> + int err; > >> + > >> + *num_tx =3D *num_rx =3D 1; > >> + > >> + if (!np || !of_device_is_available(np)) > >> + return; > >> + > >> + /* parse the num of tx and rx queues */ > >> + err =3D of_property_read_u32(np, "fsl,num-tx-queues", num_tx= ); > >> + err |=3D of_property_read_u32(np, "fsl,num-rx-queues", num_r= x); > >> + if (err) { > >> + *num_tx =3D 1; > >> + *num_rx =3D 1; > > Shouldn't these be handled seperately? So that if only one of those > > properties is given in DT the specified value for that property sho= uld > > be used? >=20 > I worry about asymmetric design in future. > Then why do you use two distinct properties in the first place? > And use two property is the easy debug two directory. >=20 I don't understand this sentence. Lothar Wa=C3=9Fmann --=20 ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstra=C3=9Fe 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Gesch=C3=A4ftsf=C3=BChrer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________