From: David Miller <davem@davemloft.net>
To: ecree@solarflare.com
Cc: nikolay@redhat.com, netdev@vger.kernel.org, ben@decadent.org.uk,
sshah@solarflare.com, linux-net-drivers@solarflare.com
Subject: Re: [PATCH net] sfc: fix addr_list_lock spinlock use before init
Date: Tue, 16 Sep 2014 16:33:57 -0400 (EDT) [thread overview]
Message-ID: <20140916.163357.1799289058951971945.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LFD.2.03.1409161704180.25290@solarflare.com>
From: Edward Cree <ecree@solarflare.com>
Date: Tue, 16 Sep 2014 17:05:21 +0100
> Reported by Nikolay Aleksandrov. In efx_init_port() we call
> efx_mac_reconfigure() to work around a Falcon/A1 limitation, and this calls
> efx_{arch}_filter_sync_rx_mode(), which takes the addr_list_lock; but this
> lock is uninitialised, because we haven't called register_netdevice() yet.
> So, in efx_farch_filter_sync_rx_mode(), check efx_dev_registered() before
> doing anything else.
> The EF10 equivalent, efx_ef10_filter_sync_rx_mode(), already has the
> corresponding check.
>
> Signed-off-by: Edward Cree <ecree@solarflare.com>
> Tested-by: Nikolay Aleksandrov <nikolay@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2014-09-16 20:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 12:55 [PATCH net] sfc: fix addr_list_lock spinlock use before init Nikolay Aleksandrov
2014-09-16 15:05 ` Edward Cree
2014-09-16 15:20 ` Nikolay Aleksandrov
2014-09-16 15:57 ` Edward Cree
2014-09-16 16:02 ` Nikolay Aleksandrov
2014-09-16 16:05 ` Edward Cree
2014-09-16 20:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140916.163357.1799289058951971945.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=ecree@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=sshah@solarflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).