* [net-next PATCH] net: sched: cls_u32: rcu can not be last node
@ 2014-09-17 5:34 John Fastabend
2014-09-17 5:54 ` Oliver Hartkopp
0 siblings, 1 reply; 4+ messages in thread
From: John Fastabend @ 2014-09-17 5:34 UTC (permalink / raw)
To: xiyou.wangcong, davem, eric.dumazet; +Cc: netdev, jhs
tc_u32_sel 'sel' in tc_u_knode expects to be the last element in the
structure and pads the structure with tc_u32_key fields for each key.
kzalloc(sizeof(*n) + s->nkeys*sizeof(struct tc_u32_key), GFP_KERNEL)
CC: Eric Dumazet <edumazet@google.com>
Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
---
net/sched/cls_u32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c
index eceeb04..be24e7e 100644
--- a/net/sched/cls_u32.c
+++ b/net/sched/cls_u32.c
@@ -64,8 +64,8 @@ struct tc_u_knode {
u32 __percpu *pcpu_success;
#endif
struct tcf_proto *tp;
- struct tc_u32_sel sel;
struct rcu_head rcu;
+ struct tc_u32_sel sel;
};
struct tc_u_hnode {
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [net-next PATCH] net: sched: cls_u32: rcu can not be last node
2014-09-17 5:34 [net-next PATCH] net: sched: cls_u32: rcu can not be last node John Fastabend
@ 2014-09-17 5:54 ` Oliver Hartkopp
2014-09-17 16:40 ` Cong Wang
0 siblings, 1 reply; 4+ messages in thread
From: Oliver Hartkopp @ 2014-09-17 5:54 UTC (permalink / raw)
To: John Fastabend, xiyou.wangcong, davem, eric.dumazet; +Cc: netdev, jhs
Please add an appropriate comment to the *code* to prevent this knowledge to
disappear. No one will search/find this in git commit messages next time.
Tnx
Oliver
On 17.09.2014 07:34, John Fastabend wrote:
> tc_u32_sel 'sel' in tc_u_knode expects to be the last element in the
> structure and pads the structure with tc_u32_key fields for each key.
>
> kzalloc(sizeof(*n) + s->nkeys*sizeof(struct tc_u32_key), GFP_KERNEL)
>
> CC: Eric Dumazet <edumazet@google.com>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
> ---
> net/sched/cls_u32.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c
> index eceeb04..be24e7e 100644
> --- a/net/sched/cls_u32.c
> +++ b/net/sched/cls_u32.c
> @@ -64,8 +64,8 @@ struct tc_u_knode {
> u32 __percpu *pcpu_success;
> #endif
> struct tcf_proto *tp;
> - struct tc_u32_sel sel;
> struct rcu_head rcu;
> + struct tc_u32_sel sel;
> };
>
> struct tc_u_hnode {
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [net-next PATCH] net: sched: cls_u32: rcu can not be last node
2014-09-17 5:54 ` Oliver Hartkopp
@ 2014-09-17 16:40 ` Cong Wang
2014-09-17 17:31 ` John Fastabend
0 siblings, 1 reply; 4+ messages in thread
From: Cong Wang @ 2014-09-17 16:40 UTC (permalink / raw)
To: Oliver Hartkopp
Cc: John Fastabend, David Miller, Eric Dumazet,
Linux Kernel Network Developers, Jamal Hadi Salim
On Tue, Sep 16, 2014 at 10:54 PM, Oliver Hartkopp
<socketcan@hartkopp.net> wrote:
> Please add an appropriate comment to the *code* to prevent this knowledge to
> disappear. No one will search/find this in git commit messages next time.
>
+1
Even though I dig git log, I agree adding a one-line comment is better.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [net-next PATCH] net: sched: cls_u32: rcu can not be last node
2014-09-17 16:40 ` Cong Wang
@ 2014-09-17 17:31 ` John Fastabend
0 siblings, 0 replies; 4+ messages in thread
From: John Fastabend @ 2014-09-17 17:31 UTC (permalink / raw)
To: Cong Wang
Cc: Oliver Hartkopp, David Miller, Eric Dumazet,
Linux Kernel Network Developers, Jamal Hadi Salim
On 09/17/2014 09:40 AM, Cong Wang wrote:
> On Tue, Sep 16, 2014 at 10:54 PM, Oliver Hartkopp
> <socketcan@hartkopp.net> wrote:
>> Please add an appropriate comment to the *code* to prevent this knowledge to
>> disappear. No one will search/find this in git commit messages next time.
>>
>
> +1
>
> Even though I dig git log, I agree adding a one-line comment is better.
>
Sure I'll add a comment at the end of the structure.
Thanks.
--
John Fastabend Intel Corporation
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-17 17:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-17 5:34 [net-next PATCH] net: sched: cls_u32: rcu can not be last node John Fastabend
2014-09-17 5:54 ` Oliver Hartkopp
2014-09-17 16:40 ` Cong Wang
2014-09-17 17:31 ` John Fastabend
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).