* [net-next PATCH v3] net: sched: cls_u32: rcu can not be last node
@ 2014-09-17 18:11 John Fastabend
2014-09-17 18:51 ` Eric Dumazet
2014-09-19 21:06 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: John Fastabend @ 2014-09-17 18:11 UTC (permalink / raw)
To: xiyou.wangcong, davem, eric.dumazet; +Cc: netdev, jhs
tc_u32_sel 'sel' in tc_u_knode expects to be the last element in the
structure and pads the structure with tc_u32_key fields for each key.
kzalloc(sizeof(*n) + s->nkeys*sizeof(struct tc_u32_key), GFP_KERNEL)
CC: Eric Dumazet <edumazet@google.com>
Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
---
net/sched/cls_u32.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c
index eceeb04..730edb2 100644
--- a/net/sched/cls_u32.c
+++ b/net/sched/cls_u32.c
@@ -64,8 +64,11 @@ struct tc_u_knode {
u32 __percpu *pcpu_success;
#endif
struct tcf_proto *tp;
- struct tc_u32_sel sel;
struct rcu_head rcu;
+ /* The 'sel' field MUST be the last field in structure to allow for
+ * tc_u32_keys allocated at end of structure.
+ */
+ struct tc_u32_sel sel;
};
struct tc_u_hnode {
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [net-next PATCH v3] net: sched: cls_u32: rcu can not be last node
2014-09-17 18:11 [net-next PATCH v3] net: sched: cls_u32: rcu can not be last node John Fastabend
@ 2014-09-17 18:51 ` Eric Dumazet
2014-09-19 21:06 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2014-09-17 18:51 UTC (permalink / raw)
To: John Fastabend; +Cc: xiyou.wangcong, davem, netdev, jhs
On Wed, 2014-09-17 at 11:11 -0700, John Fastabend wrote:
> tc_u32_sel 'sel' in tc_u_knode expects to be the last element in the
> structure and pads the structure with tc_u32_key fields for each key.
>
> kzalloc(sizeof(*n) + s->nkeys*sizeof(struct tc_u32_key), GFP_KERNEL)
>
> CC: Eric Dumazet <edumazet@google.com>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
> ---
> net/sched/cls_u32.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Thanks John !
Acked-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [net-next PATCH v3] net: sched: cls_u32: rcu can not be last node
2014-09-17 18:11 [net-next PATCH v3] net: sched: cls_u32: rcu can not be last node John Fastabend
2014-09-17 18:51 ` Eric Dumazet
@ 2014-09-19 21:06 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-09-19 21:06 UTC (permalink / raw)
To: john.fastabend; +Cc: xiyou.wangcong, eric.dumazet, netdev, jhs
From: John Fastabend <john.fastabend@gmail.com>
Date: Wed, 17 Sep 2014 11:11:46 -0700
> tc_u32_sel 'sel' in tc_u_knode expects to be the last element in the
> structure and pads the structure with tc_u32_key fields for each key.
>
> kzalloc(sizeof(*n) + s->nkeys*sizeof(struct tc_u32_key), GFP_KERNEL)
>
> CC: Eric Dumazet <edumazet@google.com>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Applied, thanks John.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-19 21:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-17 18:11 [net-next PATCH v3] net: sched: cls_u32: rcu can not be last node John Fastabend
2014-09-17 18:51 ` Eric Dumazet
2014-09-19 21:06 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).