From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Westphal Subject: Re: Cannot move macvlan interface on top of bonding device Date: Wed, 17 Sep 2014 21:06:26 +0200 Message-ID: <20140917190626.GA11354@breakpoint.cc> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Francesco Ruggeri , netdev , "David S. Miller" , Weilong Chen , Florian Westphal To: Cong Wang Return-path: Received: from Chamillionaire.breakpoint.cc ([80.244.247.6]:32909 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756013AbaIQTGe (ORCPT ); Wed, 17 Sep 2014 15:06:34 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Cong Wang wrote: > On Wed, Sep 17, 2014 at 8:56 AM, Francesco Ruggeri wrote: > > This used to work in older releases. > > The problem seems to be that commit f939981492 sets NETIF_F_NETNS_LOCAL > > on bonding interfaces, and commit 797f87f83 causes macvlan interfaces > > to inherit its features from the lower device. > > > > Is there a reason why NETIF_F_NETNS_LOCAL should be inherited from the > > lower device > > by macvlan interfaces? > > commit 797f87f83 looks wrong, it should not inherit NETIF_F_NETNS_LOCAL, > so just clear this flag. Please submit a patch. Under which conditions would NETIF_F_NETNS_LOCAL have to be inherited? (i.e., why is it inheritable in the first place?)