From: David Miller <davem@davemloft.net>
To: sd@queasysnail.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: fix sparse warnings in SNMP_UPD_PO_STATS(_BH)
Date: Fri, 19 Sep 2014 17:22:57 -0400 (EDT) [thread overview]
Message-ID: <20140919.172257.1570134006629760373.davem@davemloft.net> (raw)
In-Reply-To: <20140917212312.GA13866@kria>
From: Sabrina Dubroca <sd@queasysnail.net>
Date: Wed, 17 Sep 2014 23:23:12 +0200
> ptr used to be a non __percpu pointer (result of a this_cpu_ptr
> assignment, 7d720c3e4f0c4 ("percpu: add __percpu sparse annotations to
> net")). Since d25398df59b56 ("net: avoid reloads in SNMP_UPD_PO_STATS"),
> that's no longer the case, SNMP_UPD_PO_STATS uses this_cpu_add and ptr
> is now __percpu.
>
> Silence sparse warnings by preserving the original type and
> annotation, and remove the out-of-date comment.
>
> warning: incorrect type in initializer (different address spaces)
> expected unsigned long long *ptr
> got unsigned long long [noderef] <asn:3>*<noident>
> warning: incorrect type in initializer (different address spaces)
> expected void const [noderef] <asn:3>*__vpp_verify
> got unsigned long long *<noident>
> warning: incorrect type in initializer (different address spaces)
> expected void const [noderef] <asn:3>*__vpp_verify
> got unsigned long long *<noident>
>
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Applied, thanks.
prev parent reply other threads:[~2014-09-19 21:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 21:23 [PATCH net-next] net: fix sparse warnings in SNMP_UPD_PO_STATS(_BH) Sabrina Dubroca
2014-09-17 22:43 ` Hannes Frederic Sowa
2014-09-19 21:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140919.172257.1570134006629760373.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).